- ๐ง๐ทBrazil renatog Campinas
I also continue seeing.
Before patch:
<!-- THEME DEBUG --> <!-- THEME HOOK: 'views_view_rss' --> <!-- BEGIN OUTPUT from 'core/modules/views/templates/views-view-rss.html.twig' --> <?xml version="1.0" encoding="utf-8"?> <rss version="2.0" xml:base="http://drupal10.lndo.site/" xmlns:dc="http://purl.org/dc/elements/1.1/"> <channel> <title>Blog Posts</title> <link>http://drupal10.lndo.site/</link> <description></description> <language>en</language> <!-- THEME DEBUG --> <!-- THEME HOOK: 'views_view_row_rss' --> <!-- BEGIN OUTPUT from 'core/modules/views/templates/views-view-row-rss.html.twig' --> <item> <title>Second Blog</title> <link>http://drupal10.lndo.site/blog-2</link> <description> <!-- THEME DEBUG --> <!-- THEME HOOK: 'field' --> <!-- FILE NAME SUGGESTIONS: * field--node--title--blog.html.twig x field--node--title.html.twig * field--node--blog.html.twig * field--title.html.twig * field--string.html.twig * field.html.twig --> <!-- BEGIN OUTPUT from 'core/modules/node/templates/field--node--title.html.twig' --> <span>Second Blog</span> <!-- END OUTPUT from 'core/modules/node/templates/field--node--title.html.twig' -->
After patch:
<?xml version="1.0" encoding="utf-8"?> <rss xmlns:dc="http://purl.org/dc/elements/1.1/" version="2.0" xml:base="http://drupal10.lndo.site/"> <channel> <title>Blog Posts</title> <link>http://drupal10.lndo.site/</link> <description/> <language>en</language> <item> <title>Second Blog</title> <link>http://drupal10.lndo.site/blog-2</link> <description> <!-- THEME DEBUG --> <!-- THEME HOOK: 'field' --> <!-- FILE NAME SUGGESTIONS: * field--node--title--blog.html.twig x field--node--title.html.twig * field--node--blog.html.twig * field--title.html.twig * field--string.html.twig * field.html.twig --> <!-- BEGIN OUTPUT from 'core/modules/node/templates/field--node--title.html.twig' --> <span>Second Blog</span> <!-- END OUTPUT from 'core/modules/node/templates/field--node--title.html.twig' --> <!-- THEME DEBUG --> <!-- THEME HOOK: 'field' --> <!-- FILE NAME SUGGESTIONS: * field--node--uid--blog.html.twig x field--node--uid.html.twig * field--node--blog.html.twig * field--uid.html.twig * field--entity-reference.html.twig * field.html.twig --> <!-- BEGIN OUTPUT from 'core/modules/node/templates/field--node--uid.html.twig' --> <span>
- ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
VladimirAus โ changed the visibility of the branch 2796453-rss-output-not to hidden.
- Status changed to Needs review
7 months ago 3:22pm 23 June 2024 - ๐ง๐ทBrazil renatog Campinas
So itโs ready to review?!
Feel free to update if not yet
- Status changed to Needs work
7 months ago 4:42pm 23 June 2024 - ๐บ๐ธUnited States smustgrave
Issue summary still appears to need to updating.
Can the MR be updated to 11.x vs 11.0.x please
- ๐ณ๐ฟNew Zealand quietone
Fixes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
VladimirAus โ changed the visibility of the branch 2796453-rss-output-not to active.
- ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
VladimirAus โ changed the visibility of the branch 2796453-twig-rss-output-d11 to hidden.
- Status changed to Needs review
6 months ago 1:44pm 17 July 2024 - First commit to issue fork.
Observed test failures, found there are some PHP coding standard related test failures , fixed those.
pipeline passed successfully & MR is mergeable now.
- ๐ฎ๐ณIndia ankitv18
$debug_blacklisted = isset($variables['view']) && ($variables['view']->getDisplay()->getType() == 'feed');
This will output TRUE or FALSE (which was the objective)
What are your thoughts?
- ๐ฎ๐ณIndia ankitv18
Pipelines are passing now ~~ keeping this in review for further suggestions.
- Status changed to Needs work
6 months ago 12:51am 22 July 2024 - ๐บ๐ธUnited States smustgrave
Seems like a fix that will need test coverage.
@smustgrave, Need guidance there for test coverage, As we know issue replicate when theme debug enable, generally when we add test theme debug not visible for those generated test file.
Any suggestion for how can I enable the theme debug for test files so that to replicate issue for test coverage.