Change $info array argument to system_get_module_admin_tasks() to $name

re-roll for 10.1

valid patch

The last submitted patch, 28: 2466933-27.patch, failed testing. View results →

random failure

Can the issue summary proposed solution be updated please.

Also this appears to just be removing vs deprecating. Any concern with breaking a contrib module?

I think we can add deprecation but it's can be caught with phpstan - something pass more then one argument to function that expects only one)

Here's a patch to narrow down API to expected information only (human readable module name)

It will help of we'll change resulting array to some value object

+++ b/core/modules/system/system.module
@@ -972,14 +972,11 @@ function system_admin_compact_mode() {
-function system_get_module_admin_tasks($module, array $info) {
+function system_get_module_admin_tasks($module) {

@@ -1026,7 +1023,7 @@ function system_get_module_admin_tasks($module, array $info) {
-        'title' => t('Configure @module permissions', ['@module' => $info['name']]),
+        'title' => t('Configure @module permissions', ['@module' => \Drupal::service('extension.list.module')->getName($module)]),

as it consumes a string and we gonna formalize extension info structure it makes sense to change type to array|string

And there's just a few usages in contrib

The last submitted patch, 33: 2466933-33.patch, failed testing. View results →

Fix typo

If the issue summary could be updated also please.

@andypost looking at "Use to pass only $info["name"] instead" that doesn't read right to me. What about just "Pass only $info["name"]"

Thanks, fixed and added deprecation test

Thanks!

The last submitted patch, 38: 2466933-38.patch, failed testing. View results →

Random failure

The last submitted patch, 38: 2466933-38.patch, failed testing. View results →

Fixed this typo on commit:

diff --git a/core/modules/system/system.module b/core/modules/system/system.module
index 5f79fca5b8..9a0926a9a9 100644
--- a/core/modules/system/system.module
+++ b/core/modules/system/system.module
@@ -983,7 +983,7 @@ function system_admin_compact_mode() {
  */
 function system_get_module_admin_tasks($module, string|array $module_name) {
   if (!is_string($module_name)) {
-    @trigger_error('Calling ' . __FUNCTION__ . '() with $module_name argument as array is deprecated in drupal:10.2.0 and is required to be staring from drupal:11.0.0. Pass only $info["name"] instead. See https://www.drupal.org/node/3357711', E_USER_DEPRECATED);
+    @trigger_error('Calling ' . __FUNCTION__ . '() with $module_name argument as array is deprecated in drupal:10.2.0 and is required to be string from drupal:11.0.0. Pass only $info["name"] instead. See https://www.drupal.org/node/3357711', E_USER_DEPRECATED);
     $module_name = $module_name['name'];
   }
 

Committed/pushed to 10.2.x, thanks!

This is only used in two places in core - AdminController in system module and HelpController in help module. I think we could make it a trait in system module to get it out of .module altogether? Tagging for a follow-up. Since this issue is already eight years old I didn't want to derail it by proposing that for here.

Thank you!

Follow-up already exists 📌 Move system_get_module_admin_tasks() into a service and deprecate it Fixed

Automatically closed - issue fixed for 2 weeks with no activity.

Published the CR