🇨🇦Canada @bbombachini

I'm having the same issue on 2.0.7 and the patch got successfully applied. Any way we can commit this to 2.0.7 too?

I was having a weird issue where authenticated users were seeing flagged content from other users. After installing and inspecting the cache using cache_review module I also noticed that user was missing from cache context.
After your patch I can see the proper user context got added.

If it helps I have this issue on a site I have installed from scratch which I have copied over the config from another site that I have migrated from switfmailer to symfony_mailer.
Now, I tried to re-save the config, I've removed manually and re-imported, and I still get this error.

Hope this helps.

Thanks @RichardGaunt, updating manually was a bit of a pain. I had to use the temporary patch on #109 ✨ CKEditor 5 support for Content Templates Needs review and I've deleted them before recreating.

I had an error that when re-saving content without a thumb_alternative value, it was saving as thumb_alternative: null and that was invalid, import would fail, then I couldn't delete the config.

Another issue I'm currently having is that if I add a div with 3 columns for ex, there's no way for me to add a paragraph after the template. I can hit enter and add as many paragraphs as I want, but I'd still be inside the template. I think we're missing the implementation of these handlers that we see on media embed:

So, I was using an early patch before and it was working fine, but now I've tried to update to the dev version of the module and use patch #117.
This is the error I get on the console:

Object { message: "An AJAX HTTP error occurred. HTTP Result Code: 500 Debugging information follows. Path: /admin/config/content/ckeditor-templates/template-selector/full_html StatusText: 500 Service unavailable (with message)
ResponseText: The website encountered an unexpected error. Try again later.
TypeError: Cannot assign string to property Drupal\ckeditor_templates\Entity\CKEditorTemplates::$code of type array in Drupal\Core\Entity\\EntityBase->__construct() (line 63 of core/lib/Drupal/Core/Entity/EntityBase.php).

Seems that $code should be an array with format and value but it's being passed as a string. I cannot even open the dialog to see the templates available.

I was having the same problem and your patch resolved.

You might know but Microsoft is retiring microsoft/azure-storage-blob as of March 2024:
https://azure.microsoft.com/en-gb/updates/retirement-notice-the-azure-st...

kristiaanvandeneynde → credited bbombachini → .

I'm closing this issue in favour of https://www.drupal.org/project/domain_group/issues/3318565 🐛 Requirement conflict when upgrading Group module to 2.0beta3 Active that has a patch already.
Please contribute to that one instead.

Same, I've just re-opened this issue as I don't believe the last release was tagged correctly. I'm also getting unsupported flags with the latest module's version.

Patch did not worked for me on 10.0.9 so I'm uploading a new one.

I feel the transliterate removes most of the characters here https://www.mtu.edu/umc/services/websites/writing/characters-avoid/ but I've added what @sidharth_soman has changed.

I found another issue I think but when I try to upload a file that's called Proposed_Snow_Fence_[%#&{}\<>*?\- 20%_0-1.pdf it gets the name of - 20%_0-1.pdf because of the back slash.

Thanks Liam, I just pushed a commit, but I can't see a note about it here? Would you be able to check?
Did I do anything wrong?
3397824-the-filename-fallback

bbombachini → created an issue.

I think there's an issue with the release tag.
I'm currently on 10.1.5 so version 8.x-1.5 is showing as not compatible and I can't go to 8.x-1.6 because it's 10.2 up?

I had the same issue and in order to better track dependencies I decided to use the Composer Merge-Plugin, this is being explained on the module's README as well as the main module page and you will require and enable this plugin.

Then you'll add this to your composer.json:

"extra": { 
       "merge-plugin": {
            "include": [
                "docroot/modules/contrib/ckeditor_codemirror/composer.libraries.json"
            ]
        }
}

And then require the module, this will pull the module's dependencies for you.

EntityTypeManager dependency was added on construct but not on create so I've added that.

I know the issue has been resolved, hence closed. But is there any suggestions about how to fix the users that have already been affected?

We had the same issue updating from 2.0 -> 3.0 and running the drush eval cmd helped although I had the following warnings so I'm not sure if it's doing anything:

[warning] Trying to access array offset on value of type null media_entity_instagram.post_update.php:40
[warning] Trying to access array offset on value of type null media_entity_instagram.post_update.php:61

I also noticed that I had this error before the media_entity_instagram update hook that replaces instagram plugin by oembed:instagram and that might be related with the problem.

All good, seems to be working now, thanks @berdir.

This is the message I got @berdir:

TypeError: call_user_func(): Argument #1 ($callback) must be a valid callback, class "Drupal\group\Entity\GroupContent" not found in call_user_func() (line 400 of /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Field/FieldConfigBase.php)

#0 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Field/FieldConfigBase.php(400): call_user_func('Drupal\\group\\En...', Object(Drupal\group\Entity\GroupRelationship), Object(Drupal\Core\Field\Entity\BaseFieldOverride))
#1 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Field/FieldItemList.php(169): Drupal\Core\Field\FieldConfigBase->getDefaultValue(Object(Drupal\group\Entity\GroupRelationship))
#2 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(271): Drupal\Core\Field\FieldItemList->applyDefaultValue()
#3 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(129): Drupal\Core\Entity\ContentEntityStorageBase->initFieldValues(Object(Drupal\group\Entity\GroupRelationship), Array)
#4 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(94): Drupal\Core\Entity\ContentEntityStorageBase->doCreate(Array)
#5 /Users/admin/Sites/ulocal/docroot/modules/contrib/group/src/Entity/Storage/GroupRelationshipStorage.php(156): Drupal\Core\Entity\ContentEntityStorageBase->create(Array)
#6 /Users/admin/Sites/ulocal/docroot/modules/contrib/group/src/Entity/Group.php(145): Drupal\group\Entity\Storage\GroupRelationshipStorage->createForEntityInGroup(Object(Drupal\media\Entity\Media), Object(Drupal\group\Entity\Group), 'group_media:ima...', Array)
#7 /Users/admin/Sites/ulocal/docroot/modules/contrib/groupmedia/src/AttachMediaToGroup.php(180): Drupal\group\Entity\Group->addRelationship(Object(Drupal\media\Entity\Media), 'group_media:image')
#8 /Users/admin/Sites/ulocal/docroot/modules/contrib/groupmedia/src/AttachMediaToGroup.php(113): Drupal\groupmedia\AttachMediaToGroup->assignMediaToGroups(Array, Array)
#9 /Users/admin/Sites/ulocal/docroot/modules/contrib/groupmedia/groupmedia.module(39): Drupal\groupmedia\AttachMediaToGroup->attach(Object(Drupal\group\Entity\GroupRelationship))
#10 [internal function]: groupmedia_entity_update(Object(Drupal\group\Entity\GroupRelationship))
#11 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Extension/ModuleHandler.php(426): call_user_func_array(Object(Closure), Array)
#12 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Extension/ModuleHandler.php(405): Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}(Object(Closure), 'groupmedia')
#13 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Extension/ModuleHandler.php(433): Drupal\Core\Extension\ModuleHandler->invokeAllWith('entity_update', Object(Closure))
#14 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Entity/EntityStorageBase.php(251): Drupal\Core\Extension\ModuleHandler->invokeAll('entity_update', Array)
#15 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(900): Drupal\Core\Entity\EntityStorageBase->invokeHook('update', Object(Drupal\group\Entity\GroupRelationship))
#16 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Entity/EntityStorageBase.php(598): Drupal\Core\Entity\ContentEntityStorageBase->invokeHook('update', Object(Drupal\group\Entity\GroupRelationship))
#17 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(781): Drupal\Core\Entity\EntityStorageBase->doPostSave(Object(Drupal\group\Entity\GroupRelationship), true)
#18 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Entity/EntityStorageBase.php(523): Drupal\Core\Entity\ContentEntityStorageBase->doPostSave(Object(Drupal\group\Entity\GroupRelationship), true)
#19 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php(804): Drupal\Core\Entity\EntityStorageBase->save(Object(Drupal\group\Entity\GroupRelationship))
#20 /Users/admin/Sites/ulocal/docroot/core/lib/Drupal/Core/Entity/EntityBase.php(339): Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object(Drupal\group\Entity\GroupRelationship))
#21 /Users/admin/Sites/ulocal/docroot/modules/contrib/entitygroupfield/src/Field/EntityGroupFieldItemList.php(65): Drupal\Core\Entity\EntityBase->save()

We're on core 9.5.10 and using groups 2.2.0 and I've tried the patch attached but I still get the same issue when I try to save content with an image. I'm using groupmedia module, so it might be related.
I'm wondering if we might need a similar patch on groupmedia as well.

bbombachini → created an issue.

We were having the same issue and we figured out that the mapping of an insider role will not bypass an user that have the individual role assigned previously.

As we've migrated from groups 1, we were used to have an Drupal user with a role "group_admin" for ex and we would assign the role to this user's membership as well. And here's comes the problem, if the Drupal user has the Drupal user role "group_admin" and also a role assigned "manually" (read individually) on its group membership.

I think this could be resolved in a way to pass this check if the scope differs (in this case insider and individual) but the roles match.

If you're here and have no idea where to find the video series he's talking about, here it goes: https://www.youtube.com/playlist?list=PLWsDPX910IWxhowXYlXDrSG_A5H7_shv5

@kristiaanvandeneynde are there any plans to fix that on groups 2.0 as well?

bbombachini → made their first commit to this issue’s fork.

Ok, that's pretty lame, but there was a duplicated line setting parameters on GroupContentTranslationController causing all this.
One line... I'm submitting another patch with that fixed.

I have rebased the MR but it doesn't apply on 8.x-1.2 but only on 8.x-1.x so I have reroll the patch for 8.x-1.2

A lot of changes have been added to the delete functionality, so I prioritized what was done already instead of some changes I saw here.

I still get the same error from simple_sitemap as my previous comment #78 🐛 Menu item edit translation permission Needs work

Last patch for 1.x from @carsoncho gives me the error:

In EntityResolverManager.php line 135:

  Class "\Drupal\group_content_menu\Controller\GroupContentTranslationController" does not exist

bbombachini → created an issue.

bbombachini → made their first commit to this issue’s fork.

This issue has been also been addressed on https://www.drupal.org/project/views_load_more/issues/3290508 📌 Automated Drupal 10 compatibility fixes Fixed so if we could prioritize that one as it's also making the module D10 ready, it would be better.

This worked for me so I created a MR with the fix.

bbombachini → made their first commit to this issue’s fork.

This is great idea and it works, but I'm moving this to "Needs work" because we need a config form and be able to import/export config as well as reflect this change on schema.

Patch from #16 applies and works well on Drupal 10.0.9, Fontawesome 8.x-2.25, php 8.1.
It's just the editing and backwards compatibility that's missing.
This issue mentioned by @Daniel.Moberly on comment #21 is a ckeditor5 behavior that strips out empty inline elements and we have the same issue with a different plugin as well.

https://www.drupal.org/project/drupal/issues/3337298 🐛 [upstream] [GHS] CKEditor 5 removes empty inline elements Fixed

Sorry for all the issues with the fork, I was trying to change the target branch but I couldn't so I updated the existing fork and created a new branch on it.

This is working for me so I had removed the reroll tag and I'm marking as tested.

After May 26th, 2.1.x has been released with a D10 compatibility so I think we should focus the effort to 2.1.x branch.

I have tested 2.1.0-rc4 with D10.0 and I got the following error:

Error: Call to undefined function Drupal\flysystem\Asset\file_create_url() in Drupal\flysystem\Asset\CssOptimizer->rewriteFileURI() (line 28 of modules/contrib/flysystem/src/Asset/CssOptimizer.php).

I could see that the patch attached here fix that line but it needs a reroll.

Tested and patch is working. Moving to needs review.

Rebased and added a pseudo example. Please review.

bbombachini → made their first commit to this issue’s fork.

While testing this patch, I could not save the text editor and add video_embed_wysiwyg because it would error out saying height and weight was required and had an empty value. Please review.

bbombachini → made their first commit to this issue’s fork.

Moving this to needs work as the solution previously presented might not be the right approach.

Got this started but it needs work and I don't have a lot of experience with ckeditor 5 changes.

bbombachini → made their first commit to this issue’s fork.

If there's anyone having this issue after upgrading to D10, I'd recommend checking this pathauto issue 💬 PluginNotFoundException: The "node_type" plugin does not exist Fixed .

bbombachini → created an issue.

I'm having the same issue, I have uninstalled simplesamlphp_auth but now I get a different error:

Uninstall of simplesamlphp/composer-module-installer failed
In PluginManager.php(274) : eval()'d code line 60:

  [Error]
  Call to protected method SimpleSAML\Composer\ModuleInstaller::getPackageBasePath() from scope Simpl
  eSAML\Composer\ModuleInstallerPlugin_composer_tmp8

I was having the same issue, and the patch works for me - currently using version 3.0.0-rc2.
I'm not the best person to say if this is the right approach but it worked for me.

I have field broken into tabs on form display, so it may be part of the issue.

Changing this to needs review as there's a patch provided.

Interesting @phonkala, I'm still testing this on D9.5.3, webform 6.2.0-beta5, PHP 8.1, and the patch from #48. And I still have the same error:

TypeError: Illegal offset type in Drupal\Core\Render\Element\Checkboxes::valueCallback() (line 136 of core/lib/Drupal/Core/Render/Element/Checkboxes.php).

So I created a simple webform for testing, can you try using this form and tell me what it gives you for $element[$key] on line 36 of core/lib/Drupal/Core/Render/Element/Checkboxes.php?

uuid: 04b7199e-cd72-46ba-954d-d4e196f58f43
langcode: en
status: open
dependencies: {  }
weight: 0
open: null
close: null
uid: 85
template: false
archive: false
id: test
title: Test
description: ''
category: ''
elements: |-
  custom_composite_test:
    '#type': webform_custom_composite
    '#title': 'Custom composite test'
    '#element':
      select_options:
        '#type': webform_checkboxes_other
        '#options':
          test1: 'Test 1'
          test2: 'Test 2'
          test3: 'Test 3'
          test4: 'Test 4'
        '#title': 'Select options'
css: ''
javascript: ''
settings:
  ajax: false
  ajax_scroll_top: form
  ajax_progress_type: ''
  ajax_effect: ''
  ajax_speed: null
  page: true
  page_submit_path: ''
  page_confirm_path: ''
  page_theme_name: ''
  form_title: both
  form_submit_once: false
  form_open_message: ''
  form_close_message: ''
  form_exception_message: ''
  form_previous_submissions: true
  form_confidential: false
  form_confidential_message: ''
  form_disable_remote_addr: false
  form_convert_anonymous: false
  form_prepopulate: false
  form_prepopulate_source_entity: false
  form_prepopulate_source_entity_required: false
  form_prepopulate_source_entity_type: ''
  form_unsaved: false
  form_disable_back: false
  form_submit_back: false
  form_disable_autocomplete: false
  form_novalidate: false
  form_disable_inline_errors: false
  form_required: false
  form_autofocus: false
  form_details_toggle: false
  form_reset: false
  form_access_denied: default
  form_access_denied_title: ''
  form_access_denied_message: ''
  form_access_denied_attributes: {  }
  form_file_limit: ''
  form_attributes: {  }
  form_method: ''
  form_action: ''
  share: false
  share_node: false
  share_theme_name: ''
  share_title: true
  share_page_body_attributes: {  }
  submission_label: ''
  submission_exception_message: ''
  submission_locked_message: ''
  submission_log: false
  submission_excluded_elements: {  }
  submission_exclude_empty: false
  submission_exclude_empty_checkbox: false
  submission_views: {  }
  submission_views_replace: {  }
  submission_user_columns: {  }
  submission_user_duplicate: false
  submission_access_denied: default
  submission_access_denied_title: ''
  submission_access_denied_message: ''
  submission_access_denied_attributes: {  }
  previous_submission_message: ''
  previous_submissions_message: ''
  autofill: false
  autofill_message: ''
  autofill_excluded_elements: {  }
  wizard_progress_bar: true
  wizard_progress_pages: false
  wizard_progress_percentage: false
  wizard_progress_link: false
  wizard_progress_states: false
  wizard_start_label: ''
  wizard_preview_link: false
  wizard_confirmation: true
  wizard_confirmation_label: ''
  wizard_auto_forward: true
  wizard_auto_forward_hide_next_button: false
  wizard_keyboard: true
  wizard_track: ''
  wizard_prev_button_label: ''
  wizard_next_button_label: ''
  wizard_toggle: false
  wizard_toggle_show_label: ''
  wizard_toggle_hide_label: ''
  wizard_page_type: container
  wizard_page_title_tag: h2
  preview: 0
  preview_label: ''
  preview_title: ''
  preview_message: ''
  preview_attributes: {  }
  preview_excluded_elements: {  }
  preview_exclude_empty: true
  preview_exclude_empty_checkbox: false
  draft: none
  draft_multiple: false
  draft_auto_save: false
  draft_saved_message: ''
  draft_loaded_message: ''
  draft_pending_single_message: ''
  draft_pending_multiple_message: ''
  confirmation_type: page
  confirmation_url: ''
  confirmation_title: ''
  confirmation_message: ''
  confirmation_attributes: {  }
  confirmation_back: true
  confirmation_back_label: ''
  confirmation_back_attributes: {  }
  confirmation_exclude_query: false
  confirmation_exclude_token: false
  confirmation_update: false
  limit_total: null
  limit_total_interval: null
  limit_total_message: ''
  limit_total_unique: false
  limit_user: null
  limit_user_interval: null
  limit_user_message: ''
  limit_user_unique: false
  entity_limit_total: null
  entity_limit_total_interval: null
  entity_limit_user: null
  entity_limit_user_interval: null
  purge: none
  purge_days: null
  results_disabled: false
  results_disabled_ignore: false
  results_customize: false
  token_view: false
  token_update: false
  token_delete: false
  serial_disabled: false
access:
  create:
    roles:
      - anonymous
      - authenticated
    users: {  }
    permissions: {  }
  view_any:
    roles: {  }
    users: {  }
    permissions: {  }
  update_any:
    roles: {  }
    users: {  }
    permissions: {  }
  delete_any:
    roles: {  }
    users: {  }
    permissions: {  }
  purge_any:
    roles: {  }
    users: {  }
    permissions: {  }
  view_own:
    roles: {  }
    users: {  }
    permissions: {  }
  update_own:
    roles: {  }
    users: {  }
    permissions: {  }
  delete_own:
    roles: {  }
    users: {  }
    permissions: {  }
  administer:
    roles: {  }
    users: {  }
    permissions: {  }
  test:
    roles: {  }
    users: {  }
    permissions: {  }
  configuration:
    roles: {  }
    users: {  }
    permissions: {  }
handlers: {  }
variants: {  }

I'm on D9.5 and php 8.1

Tried the patch #48 with webforms 6.1.4 and tried the patch from the MR (https://git.drupalcode.org/project/webform/-/merge_requests/123.patch) with version 6.2.0-beta5 (latest release) and the dev version but all the 3 gave me the same error as #50:

TypeError: Illegal offset type in Drupal\Core\Render\Element\Checkboxes::valueCallback() (line 136 of /var/www/sdgs.localhost/web/core/lib/Drupal/Core/Render/Element/Checkboxes.php)

So I'm moving this to needs work.

bbombachini → created an issue.

@pmota, you are able to change the direction of the Tabs element on manage display by clicking the clog.
This is what you're supposed to see, just pick vertical/horizontal on the Direction dropdown.

For questions like this we recommend using the Drupal slack.
I'm closing this issue.