- Issue created by @bbombachini
- 🇨🇦Canada bbombachini London, ON
Thanks Liam, I just pushed a commit, but I can't see a note about it here? Would you be able to check?
Did I do anything wrong?
3397824-the-filename-fallback - Merge request !374Issue #3397824: The filename fallback cannot contain the "%" character → (Merged) created by bbombachini
- last update
about 1 year ago 536 pass - 🇺🇸United States jrockowitz Brooklyn, NY
We should go after any illegal characters that could be uploaded and included in a filename.
@see https://www.mtu.edu/umc/services/websites/writing/characters-avoid/
- 🇮🇳India sidharth_soman Bangalore
I've made changes to filter out the remaining illegal characters as mentioned in #9.
Couldn't push a new commit or my own branch due to a 403 from gitlab. Hence, uploading a patch for it.
- last update
about 1 year ago Patch Failed to Apply - Status changed to Needs review
about 1 year ago 1:21pm 31 October 2023 - 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Thanks. It would be great to have a test for this.
You may need to click "Get push access" in this issue to be able to push to the issue branch.
- last update
about 1 year ago 536 pass - 🇨🇦Canada bbombachini London, ON
I feel the transliterate removes most of the characters here https://www.mtu.edu/umc/services/websites/writing/characters-avoid/ but I've added what @sidharth_soman has changed.
I found another issue I think but when I try to upload a file that's called
Proposed_Snow_Fence_[%#&{}\<>*?\- 20%_0-1.pdf
it gets the name of- 20%_0-1.pdf
because of the back slash. - 🇫🇮Finland merilainen
I tried to apply the patch, but it would not apply to 6.2.2 nor 6.2.x-dev.
After applying the changes manually, I tested it with a filename which has spaces "test picture with spaces.png".
It worked if I don't select the "Sanitize file name" setting in the element configuration.
If I do select it, I cannot open the file from the results listing, instead I get the following error:
The requested URL "https://my-cms.lndo.site/system/files/webform/test%2520picture%2520with%2520spaces_0.png" was not found on this server.
- last update
8 months ago 535 pass, 2 fail The last submitted patch, 14: replace-illegal-characters-3397824-14.patch, failed testing. View results →
- last update
7 months ago 536 pass - last update
7 months ago 536 pass - Status changed to Fixed
7 months ago 6:31pm 4 April 2024 -
jrockowitz →
committed 74ba81f3 on 6.2.x authored by
bbombachini →
Issue #3397824 by sidharth_soman: The filename fallback cannot contain...
-
jrockowitz →
committed 74ba81f3 on 6.2.x authored by
bbombachini →
Automatically closed - issue fixed for 2 weeks with no activity.