Menu item edit translation permission

Seems like there are some test failures? Back to NW.

I modified entity annotation links of @kevin.vanbelle@skynet.be patch

Patch on #73 🐛 Menu item edit translation permission Needs work is missing the new files and doesn't apply. Neither did #71 so I have recreated a patch from these that applies to current 3.0.x-dev

Reroll of #58 against the latest 1.x version

Last patch for 1.x from @carsoncho gives me the error:

In EntityResolverManager.php line 135:

  Class "\Drupal\group_content_menu\Controller\GroupContentTranslationController" does not exist

I have rebased the MR but it doesn't apply on 8.x-1.2 but only on 8.x-1.x so I have reroll the patch for 8.x-1.2

A lot of changes have been added to the delete functionality, so I prioritized what was done already instead of some changes I saw here.

I still get the same error from simple_sitemap as my previous comment #78 🐛 Menu item edit translation permission Needs work

Ok, that's pretty lame, but there was a duplicated line setting parameters on GroupContentTranslationController causing all this.
One line... I'm submitting another patch with that fixed.

Hello!

I wanted to help contribute a patch that I was able to write. It's for the 2.x branch of the module (this is the version our customer is moving onto from 1.x) but I based the start of it all from the patch on #80.

This patch is able to get the UI functionality for letting the administrative user be able to have the Translate links in the Operations dropdown for both the Group menu and Group menu links, and help avoid the WSOD errors that I was seeing when initially trying to re-roll the patch from #80 onto the base of the 2.x branch.

The only thing that needs work on, is that in the GroupContentMenuForm.php, I had to remove the $link->isTranslatable() check because when enabling the Group Content Menu's as translatable content, it's enabling it for the entity of group_content_menu but not for the links (and I was not seeing any way to be able to see how to make it enabled). I'm hoping someone might be able to expand on my work here and be able to include this.

The issue fork is currently mixed up, some classes got duplicated code due to merge conflicts between the major branches 3.x and 8.x-1.x.

Here is an updated patch for 8.x-1.x.

I don't think the issue summary is accurate any longer. The high-level permission is not longer needed. Or is it? Can we verify?

I'll do the IS update shortly and I'm working on some updates. The code in question is a good starting point, but it needs some dusting off.

Tests are passing green. For those using an older version of this patch, I changed the name of the translation permission to make it more English phonetic. You'll need to re-build group permissions to use the latest version with the changed permission name. But otherwise, the latest version shrink the number of changes to a much more manageable lines of changes. Sadly, still needs tests. But manual testing, things work.

Tests added. I just need someone, anyone to chime in that this fixes the issue for _your_ site.

Thanks everyone for your contributions here. I'm pretty sure we might have missed something in this massive effort. But... we can fix that in follow-ups. LGTM.

Actually, this doesn't merge cleanly into 2.x. Re-opening for someone to re-base.

Resolved the conflicts.