Yes comment #2 works - I have made a patch against 7.x-3.x-dev.
Here is a patch the works for me on php 8.2
Patch on #4 is not working for me on php 8.2
I will attach a new patch that is working.
I am trying to solve the layout builder translation issues for the first time and I am running into difficulties.
If I use patch 75 on its own I get the following error message:
Error: Interface "Drupal\layout_builder\TranslatableSectionStorageInterface" not found in /var/www/pwnhc/web/core/modules/layout_builder/src/DefaultsSectionStorageInterface.php on line 12 #0 /var/www/pwnhc/vendor/composer/ClassLoader.php(571): include()
If I apply the patch in this issue, https://www.drupal.org/project/drupal/issues/2946333 📌 Allow synced Layout override Translations: translating labels and inline blocks Needs work based off this merge request https://git.drupalcode.org/project/drupal/-/merge_requests/5956#note_259636 then that error goes away and I get a button called "Translate Layout".
The old merge request listed above (https://git.drupalcode.org/project/drupal/-/merge_requests/1504#note_194458) no longer applies to 10.2 - If this new patch would have fully worked I would replace it in the description.
I am having 2 issues with the 2 patches. Firstly I am using a path based URL and the path is duplicated in the Translate Layout button link so it goes to a page not found.
Details
- The manage display page is http://web2.local/pwnhc/en/admin/structure/types/manage/events/display
- The translate button points to http://web2.local/pwnhc/pwnhc/en/admin/structure/types/manage/events/dis...
- It should point to http://web2.local/pwnhc/en/admin/structure/types/manage/events/display/t...
Secondly with the corrected link I gotten 2 different outputs
- An access denied error on the page. This was on an existing content type
- On a new content type I go this: Error: Call to a member function get() on null in Drupal\layout_builder\Plugin\SectionStorage\DefaultsSectionStorage->getTranslatedComponentConfiguration() (line 481 of /var/www/pwnhc/web/core/modules/layout_builder/src/Plugin/SectionStorage/DefaultsSectionStorage.php).
If anyone can guide me to get better results I would appreciate it.
I add a new commit to the merge request to update the dependencies that are in the composer.json. With out this it doesn't seem possible to update with the patch.
I unfortunately couldn't test this directly because it seems composer searches for dependencies before applying patches. I have tried with no success to use the merge request branch as my source. I am not sure of the syntax to put in my composer.json. I have tested this by creating my own repo of this and using that package.
circuscowboy → made their first commit to this issue’s fork.
Forgot to add dependency
Fixed the patch to work with 3.3.x branch
Patch on #73 🐛 Menu item edit translation permission Needs work is missing the new files and doesn't apply. Neither did #71 so I have recreated a patch from these that applies to current 3.0.x-dev
Here is a patch
circuscowboy → created an issue.
Here is a patch
circuscowboy → created an issue.
Here is a patch that works for me
circuscowboy → created an issue.
Oops - the first errors were the ones that stopped the site from bootstrapping but there are a number of others included in this patch
Here is the patch
circuscowboy → created an issue.
I guess it needs review again.
Per sthomen's comment on comment #97 → I have adapted the patch to only add the new #theme_wrapper if one doesn't already exist. This allows the patch to work with paragraphs enabled.
If I am not mistaken the process is that drupal 8 will be patched and then the patch will get back ported to D7 and all can be done in the same issue. That is what I have seen in the past.
I have been bringing this patch along for months so it would be good to get committed. (D7 - haven't used on D8 so can't review)