Drupal 10 compatibility

Checked the module with Rector and it only found issues in the .info.yml files. Hope this merge request helps!

I've updated this to include an access check on the entity queries, as I believe Drupal 10 now requires this, having been deprecated in D9.2. This came up in as flagged. I originally thought the accessCheck only applied to content, such as nodes.

Yes, I've tested this properly now. Drupal 10 does not require the accessCheck on these types of entities. Apologies for adding the unnecessary commits.

However, I can confirm the original commits to remove the core key and update the core_version_requirements key is enough to get this working in Drupal 10. So it's a +1 from me.

RTBC.

The plain diff of the MR is correct.

https://git.drupalcode.org/project/wordpress_migrate/-/merge_requests/8....

Any chance we could get the work to date committed and released?

I add a new commit to the merge request to update the dependencies that are in the composer.json. With out this it doesn't seem possible to update with the patch.

I unfortunately couldn't test this directly because it seems composer searches for dependencies before applying patches. I have tried with no success to use the merge request branch as my source. I am not sure of the syntax to put in my composer.json. I have tested this by creating my own repo of this and using that package.

I agree with the fixes. Thanks for catching that. Yes it is very difficult to test these kinds of patches on real drupal sites due to the chicken-egg scenario of requiring a module that needs to patch its composer, because the patch isnt present when composer is compiling dependencies.

For that reason, this should get committed asap!

Patched version alpha6 released → . thank you all!

HongPong → closed merge request !8

Automatically closed - issue fixed for 2 weeks with no activity.