Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 16 June 2022, over 2 years ago
Updated 17 September 2023, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇬🇧United Kingdom DanLew Birmingham

    What's left to do here to get a D10 compatible release out?

  • Comment over 1 year ago →
    🇮🇳India rahul1707

    I have tested patch #3 on Drupal 9.5.7 and 10.0.3 and PHP 8.1. Patch applied cleanly, functionality is working as expected and making this module D10 compatible. Checked with upgrade status, no issue found.
    So, moving this to RTBC.

  • Comment over 1 year ago →
    🇳🇱Netherlands tadas.rimkus

    tadas.rimkus → made their first commit to this issue’s fork.

  • Status changed to RTBC over 1 year ago
  • @tadasrimkus opened merge request.
  • @tadasrimkus opened merge request.
  • Comment over 1 year ago →
    🇩🇪Germany SolimanHarkas

    I have tested patch #3 and it is also working fine with me!

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇭🇷Croatia tamerzg

    There is actually an issue when using Ajax on Views.

    This is the error:

    TypeError: $wrapper.removeOnce is not a function

    Its probably due to jquery once change in D10:
    https://www.drupal.org/node/3158256 →

  • Comment over 1 year ago →
    🇩🇪Germany Anybody Porta Westfalica

    Drupal 9 EOL is close and Drupal 10.1 is out. Any plans to fix this? Or perhaps look for new maintainers?

  • Comment over 1 year ago →
    🇮🇳India rahul1707

    Created patch to resolve "TypeError: $wrapper.removeOnce is not a function" issue.

    Kindly review.

  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India rahul1707
  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India Bushra Shaikh

    I have reviewed and checked patch#14 this works for Drupal 9.5 and Drupal 10.0. and 10.0.1
    Screenshots of the compatibility on 9.5 have been attached for reference:

    Can be move to RTBC+1

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇺🇦Ukraine i-trokhanenko Lutsk 🇺🇦

    The patches and MRs attached above apply smoothly, but unfortunately don't work as expected, @Bushra Shaikh have you tested some of them?

    Issues I found:

    • sometimes the pager disappears after clicking the "Load More" button.
    • in a recent Drupal release, the AjaxCommand viewsScrollTop was renamed to scrollTop, so, we should replace the viewsScrollTop with scrollTop in the VLMEventSubscriber.php
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇺🇦Ukraine i-trokhanenko Lutsk 🇺🇦

    I've fixed the issues I mentioned in #17 and created a new patch, please QA.

  • Comment about 1 year ago →
    t_d_d

    Applying #18 to my usecase, I found 2 bugs:

    Ajax returned twice but one result had empty data. Regardless, module's JS ran twice leading to all kind of strange behavior.

    It was caused by response having 2 different "insert" commands ("replaceWith" and "prepend" (probably something unique to my usecase)) and module was not checking whether the command it is altering is really "replaceWith" one, despite comment in code noticing the possibility there might be other "insert" commands.

    "Load more" button was staying even though there were no more results.

    It was caused by setting text for when there are no more results empty (valid option in pager settings in views). In such case, pager template does not render anything and as a result, pager is missing in new content. So far it is valid behavior, but then JS, not finding pager in new content, left old one intact.

    Attached patch adds fixes to these problems on top of #18. Module now only acts upon "replaceWith" "insert" command and when text for no more results is missing, it removes the pager entirely when there are no more results.

  • First commit to issue fork.
  • Comment about 1 year ago →
    System Message
  • Status changed to Fixed about 1 year ago
  • Comment about 1 year ago →
    🇺🇦Ukraine i-trokhanenko Lutsk 🇺🇦

    Committed the #19 patch. Thanks!

  • Comment about 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024