We tested the patch on our website and it works as expected.
Thank you very much for reaching out and for your interest in contributing to the module. I appreciate the work you’ve done so far, including the issue and merge request for Drupal 11 compatibility.
I wanted to let you know that I’ve just released an update with Drupal 11 support for the module. Given the module’s scope and relatively compact nature, I feel it’s manageable with a single maintainer, so adding additional maintainers isn’t necessary at this time.
That said, I truly appreciate your offer and your contributions. Please don’t hesitate to keep in touch if you have any additional questions about the module.
Thanks again!
I just released 2.0.1 with Drupal 11 support.
Will be released in 2.0.1
Commited.
Will be released in 2.0.1
Pushed the fix for:
The PHP open tag must be followed by exactly one blank line
Expected 1 newline at end of file; 2 found
Other issues are related to README.md which is a markdown file, not a PHP file. PHPCS tool typically focuses on PHP code style issues, not Markdown files, and it’s unusual to report warnings or errors on non-PHP files like README.md.
There is actually an issue when using Ajax on Views.
This is the error:
TypeError: $wrapper.removeOnce is not a function
Its probably due to jquery once change in D10:
https://www.drupal.org/node/3158256 →
Released in 2.0.0
Released in 2.0.0
I pushed a slightly different fix that fixes this.
#5 works
Released in 2.0.2
Renamed and reformatted.
Commited to 2.0.1 and released.
Commited to 2.0.1 and released.
Commited to 2.0.1
Works fine on 5.x, scheduled backups are created prefixed with the File Name from profile.
@Anybody I just updated PR, now $message string is built dynamically so we don't mix it with context variable. Please note that $message is not wrapped in t() as it shouldn't be, log messages are translated on display, but they are always stored in english/system language.
Gotya about Assigned field.
I updated PR with new schema number for update hook (50002).
@DamienMcKenna maybe it would be better to rename it to 9501 or 10501? That would be more according to the documentation guidelines:
- 1 or 2 digits for Drupal core compatibility (Drupal 8, 9, 10, etc.). This convention must be followed.
- 1 digit for your module's major release version; for example, for 8.x-1.* use 1, for 8.x-2.* use 2, for Core 8.0.x use 0, and for Core 8.1.x use 1. This convention is optional but suggested for clarity.
- 2 digits for sequential counting, starting with 01. Note that the x000 number can never be used: the lowest update number that will be recognized and run for major version x is x001.
@Anybody thanks for the review. I replied inside PR.
Added status message to Drupal log:
Restore completed using {backup_name} from {backup_location} into {destination} at {time}.
Created MR with added support for Encryption in scheduled backups.
Now when creating a schedule there is Backup Encryption fieldset which will be disabled if defuse php encrpytion is not installed and appropriate message is shown:
If the library is installed then you can enable/disable Encryption and set password:
Also in case of update user is asked if he wants to change the password, since pw field doesn't have default value and this will prevent overwritting password each time Schedule form is saved again.
There is also an update hook which makes sure that previous Schedule configs have default value for new encrypt fields.
Since this PR has update hook, it would be good to also merge this PR:
https://www.drupal.org/project/backup_migrate/issues/3338192
🐛
backup_migrate_update_5001 is never executed due to CORE_MINIMUM_SCHEMA_VERSION
Fixed
in order to get correct execution sequence.
Created MR, update hook is now successfully run on existing Drupal site.
tamerzg → created an issue.