- Issue created by @dev16.addweb
- 🇵🇭Philippines clarkssquared
Hi
I applied the patch and I confirmed that it fixes the PHPCS issues and the remaining issue occurs when a module is installed via composer.
➜ body_node_id_class git:(master) ✗ curl https://www.drupal.org/files/issues/2024-05-15/resolve_phpcs_issues.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1982 100 1982 0 0 3242 0 --:--:-- --:--:-- --:--:-- 3281 patching file README.md patching file body_node_id_class.module ➜ body_node_id_class git:(master) ✗ .. ➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml body_node_id_class FILE: ...9-local/web/modules/contrib/body_node_id_class/body_node_id_class.info.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by | | drupal.org packaging automatically -------------------------------------------------------------------------------- Time: 104ms; Memory: 10MB ➜ contrib git:(master) ✗RTBC +1 from me, I will retain the status to Needs Review for others to review the patch
- Status changed to RTBC
16 days ago 3:27pm 5 November 2024 - 🇭🇷Croatia tamerzg
Pushed the fix for:
The PHP open tag must be followed by exactly one blank line
Expected 1 newline at end of file; 2 foundOther issues are related to README.md which is a markdown file, not a PHP file. PHPCS tool typically focuses on PHP code style issues, not Markdown files, and it’s unusual to report warnings or errors on non-PHP files like README.md.
Automatically closed - issue fixed for 2 weeks with no activity.