Hello team!
Is this module finally going to be compatible with Drupal 10?Thank you!
- πͺπͺEstonia hkirsman
Could this be task for 2.0 only to get beta 2 out with D10 support? I've renamed the title.
Adding patch.
Fixed tests (tested on 9.5):
Upgrade Status module does not complain anymore:
- πͺπͺEstonia hkirsman
We are using this patch with Flystem S3 module and all seems good.
Could we push towards 2.0.0-beta2?
- Status changed to Needs review
over 1 year ago 12:58pm 28 April 2023 - last update
over 1 year ago 103 pass - π¨π¦Canada bbombachini London, ON
After May 26th, 2.1.x has been released with a D10 compatibility so I think we should focus the effort to 2.1.x branch.
I have tested 2.1.0-rc4 with D10.0 and I got the following error:
Error: Call to undefined function Drupal\flysystem\Asset\file_create_url() in Drupal\flysystem\Asset\CssOptimizer->rewriteFileURI() (line 28 of modules/contrib/flysystem/src/Asset/CssOptimizer.php).
I could see that the patch attached here fix that line but it needs a reroll.
- @bbombachini opened merge request.
- last update
over 1 year ago 103 pass - @bbombachini opened merge request.
- Status changed to RTBC
over 1 year ago 3:40pm 15 June 2023 - π¨π¦Canada bbombachini London, ON
Sorry for all the issues with the fork, I was trying to change the target branch but I couldn't so I updated the existing fork and created a new branch on it.
This is working for me so I had removed the reroll tag and I'm marking as tested.
- πͺπͺEstonia hkirsman
I've tested that the MR 25 fixes the last 10 issue.
- π¨π·Costa Rica maxmendez
I've tested MR 25 too and it fixes the last D10 issue
- last update
over 1 year ago 103 pass - First commit to issue fork.
- last update
over 1 year ago 103 pass -
lhridley β
committed afb21f06 on 2.1.x authored by
bbombachini β
Issue #3292158 by bbombachini, DieterHolvoet, hkirsman, Amanda95,...
-
lhridley β
committed afb21f06 on 2.1.x authored by
bbombachini β
- Status changed to Fixed
over 1 year ago 5:36pm 30 July 2023 - πΊπΈUnited States lhridley
Thank you all for your contributions! This is merged into the dev branch, pending review of other outstanding issues, we'll try to get a new RC release shortly!
- Status changed to Fixed
over 1 year ago 11:33pm 3 August 2023