Fix the declaration of the getQuery function for query building classes in Drupal 10

Facing the same issue with Drupal 10.1.0-beta1, PHP 8.1 on install from the browser and by drush.

Check other getQuery functions

Attaching a patch file for Webform 6.2.0-beta5

patch #11 rules :) thanks a lot

Hm, this is ugly. The new core method was added in 📌 Allow EntityListBuilder::getEntityIds() to easily extend the query Fixed and it just happens to conflict with the method name that webform uses a lot.

Possibly the method should be renamed instead here, it's not really an override of the parent method but something else, the switch between getEntityIds() and getQuery() is different.

I also don't think that getQuery from modules/webform_submission_log/src/WebformSubmissionLogManager.php has anything to do with core change to ListBuilder.

Although I'm not versed enough to review the actual code, I verified #11 fixed the issue for me.

Moving this to needs work as the solution previously presented might not be the right approach.

I disagree that we should reject the patch in #11 because of aesthetics. Typing the return object in the method signature is a valuable type hint that PHP allows. We should do it more often.

I'm using patch #11 for now.

It's an unrelated change that implements its own interface which was not changed, it's not even the same return type, I fully agree that this doesn't belong in here. Same for WebformSubmissionExporter. This is tricky enough as it is, lets focus on the actually required changes.

The different arguments are tricky as well, but changing the name or the arguments (they seem to come from properties always, so they could also just be dropped) has its own risk of introducing more issues if people customize those classes on their own.

I updated the patch to only have the required changes. I am adding a change to require-dev though so we can actually test this on D10+, feel free to commit that separately. I didn't update the MR, might be easier to proceed with the patch as the MR also had unrelated changes it seems.

Here's a patch that applies on 6.2.x.

THANKS! Applying the patch from #20 fixed the issue for me.

+1 on #20 for keeping the return type hints in the method signature.

I also brought this up in slack and core maintainers would be open to rename the added core method to not break Webform: https://drupal.slack.com/archives/C1BMUQ9U6/p1684156596053419.

I opened 📌 Rename EntityListBuilder::getQuery() to something less generic Fixed to solve this in core, but we do not have much time to get this in.

📌 Rename EntityListBuilder::getQuery() to something less generic Fixed landed.

Thanks @longwave, so that means we should close this works as designed?
Is the core fix perhaps worth a Drupal 10.1.0-beta2 release to fix this critical conflict? Or is betaX after beta1 also tied to a schedule?

Yeah, this could have been closed as a won't fix too as it will be fixed in the next core beta/rc release.

Automatically closed - issue fixed for 2 weeks with no activity.