Rename EntityListBuilder::getQuery() to something less generic

Created on 21 May 2023, about 1 year ago
Updated 22 May 2023, about 1 year ago

Problem/Motivation

In πŸ“Œ Allow EntityListBuilder::getEntityIds() to easily extend the query Fixed we added a new method \Drupal\Core\Entity\EntityListBuilder::getQuery().

However, this breaks Webform; see πŸ› Fix the declaration of the getQuery function for query building classes in Drupal 10 Fixed - while we usually do not bend to support contrib, it seems pragmatic in this case as Webform already uses getQuery() a lot for method names and we have made their life unintentionally difficult with this change.

Because we introduced this late in 10.1.x dev cycle @catch and I discussed this and we consider it safe to rename the method as long as it is done before 10.1.0 is released.

Steps to reproduce

Proposed resolution

Rename the method to getEntityListQuery().

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Fixed

Version

10.1 ✨

Component
EntityΒ  β†’

Last updated about 2 hours ago

Created by

πŸ‡¬πŸ‡§United Kingdom longwave UK

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024