🇬🇧United Kingdom @Robert Castelo

Thanks for reporting the issue.

Would be useful to know:

Have there been any patches added to Legal?

Is it an update from previous version of Legal or fresh install?

OK, so the issue is a patch has been applied and now that patch throws an error with the latest release.

The release is working fine.

There is no file modules/contrib/legal/src/EventSubscriber/LegalNavigationLock.php in the 3.0.2 release.

Have you perhaps applied a patch that adds that file?

I'm going to do thorough manual testing this week and planning to do a Legal 3.0.2 release next weekend.

https://www.drupal.org/project/legal/issues/3376194 📌 Make user ID validation logic more defensive Fixed may affect this.

In future I'll do a re-write to move to session store instead of cookie, but that may be a few months away.

I don't have option to do this until next major branch (4.0.x-dev).

Added in https://www.drupal.org/project/legal/issues/3376194 📌 Make user ID validation logic more defensive Fixed .

The Drupal out of the box behaviour is that when a user visits a page and gets a 404 if they click on the login link they go to the login page and submit their details, they are then redirected to their account page.

@UnsettlingTrend is your site redirecting back to the page that initially gave a 404? How are you doing that?

Note: if using the User Login block Legal will redirect back to the page that initially gave a 404.

I wasn't able to change the second $_REQUEST to \Drupal::destination()->get() as it gives different results and breaks redirects.

\Drupal::destination()->get() will always return a default redirect path for a form, $_REQUEST['destination'] returns an empty string if it's not set.

@Grevil maybe something in the .gitlab-ci.yml file?

What else is different between local and Gitlab environments.

Thanks @Arlina adding configurable redirect as an option.

If you have time to write a test for this feature would be much appreciated!

Added specific exemption for Masqurading users.

Fixed as part of another issue.

Changes in #11 already added to 3.0.x 15 months ago as part of another commit.

"drishu, 15 months ago (February 14th, 2023 4:06 PM) Fix tests."

Can't reproduce. Does this still happen with version 3?

I haven't been able to reproduce this. Feel welcome to re-open this issue if you can document steps to reproduce the issue.

Merged. Thanks for review Wim Leers.

Why do we need to "exit gracefully" if someone tampers with the cookie value?

Fixed as part of another issue.

@Grevil I fixed this already, but let me know if there's anything from this branch you think should be merged in.

Regression issue fixed.

@Grevil I fixed the tests and also an issue with the one time login message not appearing on the password reset page.

I already credited everyone who contributed code in the "Credit & committing" section when merging the issue through the issue page, let me know if there's anything else that needs to be done to give credit.

@Grevil I've merged but still need to make some changes before I consider this issue resolved, which I'm currently working on.

I've given attribution when I merged, maybe that commit is still local and I need to push to origin.

Commit:
e99a8547c3f9d5cee4845be049b7f2acabec9274 [e99a854]

Issue #3074688 by johne, jurgenhaas, ankithashetty, danielspeicher, tobiasb, Grevil, JayDarnell, Ron Collins, mrinalini9, fjgarlin: [PP-1] Password can not be reset, when user hasn't accepted the legal terms yet

@Grevil not sure I understand this issue....manually testing I wasn't able to reproduce the issue at all.

Am I right in thinking that this is now just an issue with automated tests?

Message is not shown at all when user needs to accept T&C.

Steps:

1. Create new T&C version
2. Use one time login link
3. User is asked to accept T&C - accept
4. User is shown password reset page - no message is shown

Hi @anybody and @grevil I've almost finished the Open Source contribution I have to get over the line this week (https://www.drupalcamp.ai) and will be free from Friday to start doing a clear out of Legal issues.

Thanks for the offer to help maintain Legal module, and thanks for the patches, appreciated!

I'm going to decline because I have a plan for this module which will require me to restrict maintenance access to really make it work.

I usually do a big clean out of issues once a year as it's easier to work on them in one go, and it looks like I'm going to have some time in May, so I'm looking forward to getting anything RTBC into the next release and a Drupal 11 release ready.

Hi @mindaugasd while I agree that collaboration on common components is a good approach, I'm concerned that aichat is at an Alpha stage, so a lot of the organisations that could potentially use openai_assistants might avoid it as part of a policy of not using Alphas on production projects.

For now the UI is done on this module and I'm going to focus on other items on the roadmap, but will be happy to revisit the UI later on once other features are completed.

@btriest many thanks for helping to test this module.

I'm testing each new release on a fresh install but there may be bugs that slip through.

What version of AI Utilities do you have installed?

openai_assistants 1.0.0-beta9 needs ai_utilities 1.0.3.

Also on the command line can you run:

composer show league/commonmark

To check version info for commonmark, should be 2.4.2

Any errors reported in the Drupal logs? (/admin/reports/dblog)

I think this is a promising approach.

Thanks for the advice @mindaugasd

By coincidence when I got your comment I was on a call with @Marcus_Johansson discussing AI Interpolator.

I will definitely be exploring the Huggingface module as an abstraction layer.

The other modules I may not be able to use for the moment until they get at least a beta release as most of what I'm developing will soon go on to a production site.

Dependencies now fixed.

WARNING: Enable and configure the OpenAI module before enabling this module.

If the OpenAI module tries to make an API request without the API key it will result in a blank page with error message for the whole site.

https://www.drupal.org/project/openai/issues/3403576 🐛 Getting an error on chapgpt configure page. Fixed

I think this has been fixed in OpenAI module dev but not yet in a release.

Agree x 100. While the OpenAI API service is useful to be able to quickly try out this module and explore AI assistants, and may be a good solution for some projects, many other projects will need self hosted AI or local AI.

My current thinking is that we need middleware that can provide a common API for multiple LLMs. That could be a module that provides integration with existing middleware or a module that provides the API abstraction itself.

Thanks for pointing me to AI Interpolator, I'll have a look at it's approach.

@zenimagine no upgrade path needed - just update the module and clear the Drupal cache on this page /admin/config/development/performance

Thanks Anybody and Grevil!

I've added this to the new 3.x.0 branch that's compatible with Drupal 8.9, 9, and 10.

Will do a full release with other fixes included today.

Also merged into 7.x.1 branch and will be included in next release for Drupal 7.

Thanks fjgarlin and everyone who reviewed this patch!

I've added this to the new 3.x.0 branch that's compatible with Drupal 8.9, 9, and 10.

Will do a full release with other fixes included today.

Thanks Andrew Answer!

I've added this to the new 3.x.0 branch that's compatible with Drupal 8.9, 9, and 10.

Will do a full release with other fixes included today.

Thanks Andras_Szilagyi, Grevil, yashingole, chike, and zenimagine!

I have created a 3.0.x branch for the Drupal 10 version of the module and will make a release tag today.

Thanks.

Robert Castelo → made their first commit to this issue’s fork.

Thanks.

Robert Castelo → made their first commit to this issue’s fork.

Why remove the old core version? That would prevent the module working in Drupal 8.

Thanks, looks good.

Robert Castelo → made their first commit to this issue’s fork.

Thank, merged and released as 1.0.1