Fix and add remaining test

We shouldn't forget to comment in the test code lines related to this issue from 🐛 Fix and add remaining test Needs work , so we don't introduce further regressions.

Through adjusting the tests I found a regression caused by 🐛 Reset notice is showing up twice (from core and legal module) and don't disappear after password change RTBC . I commented out the part of the test, that let them fail for now. We should comment them in again through 🐛 The one-time login message is not displayed anymore, when the user is first redirected to the T&C page. Active .

@Grevil I fixed this already, but let me know if there's anything from this branch you think should be merged in.

One test still fails in 3.0.x: https://git.drupalcode.org/project/legal/-/jobs/1603633

Had similar issues yesterday, where locally running the tests everything went green, but on remote one fails.

I'll rebase the branch on 3.0.x, try to fix the test and readd the "testPasswordResetLegalAcceptOnEveryLogin()" test.

Ok, no idea why they are failing on remote. The new test throws the same exact error as the "testPasswordResetWithoutLegalAccepted()" test in the 3.0.x phpunit job:

Failed asserting that 'http://localhost/web/legal_accept?token=9TaxWGHdTkxxh7DCswLCwFKCcxqkCjr2...' starts with "http://localhost/web/legal_accept?destination=/web/user/2/edit%3Fpass-re..."

The "pass-reset-token" is not even included in the URL for some reason... locally the tests just run fine.

@Robert Castelo maybe you have any further ideas? I'd be fine with a new release, as all tests are passing locally, but this test behavior is still quite confusing.

@Grevil maybe something in the .gitlab-ci.yml file?

What else is different between local and Gitlab environments.

I'm going to do thorough manual testing this week and planning to do a Legal 3.0.2 release next weekend.

john franklin → made their first commit to this issue’s fork.