Add exemption api to allow a Masquerade module exemption

Created on 19 December 2015, almost 9 years ago

Updated 31 May 2024, 6 months ago

Problem/Motivation

I usually install the masquerade module on my sites to allow me to become other users when they need certain kinds of support.

Is there any way to bypass legal when I masquerading as a user? If the user I'm switching to is not up to date on their waiver, it forces me to agree to it on their behalf. Even worse, it loses knowledge that I'm a masqueraded user and I don't get the links to switch back to myself (usually in the navigation menu or a block)

Steps to reproduce

Install the Masquerade module.
Update the legal text.
Masquerade as a user.
Notice you're now logged out and masquerade is essentially broken.

Proposed resolution

Add an API to allow a module to declare a circumstance where a legal module requirement might be exempt.

Remaining tasks

Needs Review from Maintainer

User interface changes

None

API changes

Addedhook_is_legal_exempt to allow developers to determine if the exemption should happen.

Data model changes

None

Release notes snippet

Addedhook_is_legal_exempt to allow developers to determine if the exemption should happen.


/**
 * Tells the Legal Module to exempt a user from accepting the Legal forms.
 *
 * @param $is_exempt
 *  Set to TRUE if the user is exempt from the legal module requirements.
 */
function hook_is_legal_exempt(&$is_exempt) {
// Masquerading users are exempt from the legal module requirement.
  if (\Drupal::service('module_handler')->moduleExists('masquerade')) {
    if (\Drupal::service('masquerade')->isMasquerading()) {
      return TRUE;
    }
  }
}

🐛 Bug report

Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States bkat

Live updates comments and jobs are added and updated live.

Incomplete comments

Merge Requests

!14Add exemption api to allow a Masquerade module exemption
Open
🇺🇸United States frob
updated 5 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇺🇸United States frob US
Instead of exempting based on some arbitrary rule, can we add a hook that allows a module developer to define the circumstance?
Comment about 1 year ago →
🇺🇸United States frob US
I pushed an MR with a new hook for allowing modules to determine if the exemption should happen.
Merge request !14Issue #2638224: Add hook for exempting users from legal requirement and added... → (Open) created by frob
Comment 6 months ago →
System Message

Robert Castelo → committed 70ce9de4 on 3.0.x
git commit -m 'Issue #2638224 by frob, mpolishchuck, mstrelan, Ludo.R:...
Status changed to Fixed 6 months ago3:23pm 17 May 2024
Comment 6 months ago →
🇬🇧United Kingdom robert castelo
Added specific exemption for Masqurading users.
Comment 6 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Pipeline finished with Failed
5 months ago
Total: 162s
#220283

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024