πŸ‡·πŸ‡΄Romania @stefan.butura

Account created on 29 June 2017, almost 7 years ago
#

Merge Requests

Recent comments

πŸ‡·πŸ‡΄Romania stefan.butura

Here is a patch replacing stable with stable9.

πŸ‡·πŸ‡΄Romania stefan.butura

Can confirm that I also had this issue and rolling back to 5.1.12 fixed it.

πŸ‡·πŸ‡΄Romania stefan.butura

Please update to the latest version and let me know if you still encounter the error.

πŸ‡·πŸ‡΄Romania stefan.butura

Thank you, 1.0.4 release should work with both D9 and D10.

πŸ‡·πŸ‡΄Romania stefan.butura

Patch attached. Requires a cache rebuild.

πŸ‡·πŸ‡΄Romania stefan.butura

stefan.butura β†’ made their first commit to this issue’s fork.

πŸ‡·πŸ‡΄Romania stefan.butura

Available in the latest version.

πŸ‡·πŸ‡΄Romania stefan.butura

This seems to only occur with JS aggregation on. Here is quick workaround to disable JS aggregation only for Gutenberg libraries until there is an official solution.

/**
 * Implements hook_library_info_alter().
 */
function MODULENAME_library_info_alter(&$libraries, $extension) {
  if ($extension === 'gutenberg') {
    foreach ($libraries as $name => &$library) {
      if (empty($library['js'])) {
        continue;
      }

      foreach ($library['js'] as $file => &$properties) {
        $properties['minified'] = TRUE;
        $properties['preprocess'] = FALSE;
      }
    }
  }
}
πŸ‡·πŸ‡΄Romania stefan.butura

Patch based on #4. Fixed an error appearing when there are no paragraphs of a specific type and removed comments.

πŸ‡·πŸ‡΄Romania stefan.butura

Updated patch to make it not do anything in cases where the headings don't have a valid hierarchy (e.g. h3 before h2)

πŸ‡·πŸ‡΄Romania stefan.butura

stefan.butura β†’ made their first commit to this issue’s fork.

πŸ‡·πŸ‡΄Romania stefan.butura

stefan.butura β†’ made their first commit to this issue’s fork.

πŸ‡·πŸ‡΄Romania stefan.butura

stefan.butura β†’ made their first commit to this issue’s fork.

πŸ‡·πŸ‡΄Romania stefan.butura

stefan.butura β†’ made their first commit to this issue’s fork.

πŸ‡·πŸ‡΄Romania stefan.butura

stefan.butura β†’ made their first commit to this issue’s fork.

πŸ‡·πŸ‡΄Romania stefan.butura

I found an issue with the patches when table titles were not unique. Tables with the same title inside the same view get the same HTML ID. Because of this, the tabledrag JS is not applied properly.

In my case, I was using 2 group by clauses - by primary category and secondary category. With the secondary category usually empty, I had many subtables with an empty table title (title = ""), and all of them had the same ID.

I'm not sure how this should be fixed. I've attached a patch that extends #54 which works for me, but it's not a very clean one.

πŸ‡·πŸ‡΄Romania stefan.butura

I found an issue with the patches when table titles were not unique. Tables with the same title inside the same view get the same HTML ID. Because of this, the tabledrag JS is not applied properly.

In my case, I was using 2 group by clauses - by primary category and secondary category. With the secondary category usually empty, I had many subtables with an empty table title (title = ""), and all of them had the same ID.

I'm not sure how this should be fixed. I've attached a patch that extends #54 which works for me, but it's not a very clean one.

πŸ‡·πŸ‡΄Romania stefan.butura

Apologies about this, should be fixed on the 3.3 release.

Production build 0.69.0 2024