🇨🇦Canada @aastrong

nx2611 → credited aastrong → .

aastrong → created an issue.

aastrong → created an issue.

This has been merged in.
Closing.

Didnt notice this already approved/merged, but did a test and looks good on my end.
I'll close the ticket.

This has been merged.
Closing.

aastrong → created an issue.

So I guess my question on this is.
At what point can I ( the other maintainer ), be able to submit for this application if the other developer is hasnt commented or doesnt have the time to push this forward ?

Id love to make what ever needed fixes, and get this approved by the security panel

Looks like it might be an issue with ctools itself:
https://www.drupal.org/project/ctools/issues/3467926 🐛 Issue: Call to a member function getRequestUri() on null in Drupal\ctools_views\Plugin\Display\Block->elementPreRender() Needs review

aastrong → created an issue.

aastrong → created an issue.

aastrong → created an issue.

@kushan4157

Is this something you can look into ?
Since I am not one of the main contributors from the start, I cannot do these commits/fixes.

But I am more than willing to help with suggestions or patches.

aastrong → created an issue.

aastrong → created an issue.

aastrong → created an issue.

+1 on this

I can hopefully look into a fix. But certainly something that I think would be very helpful.

aastrong → made their first commit to this issue’s fork.

Going to delete this in favor of posting on the existing issue.

aastrong → created an issue.

aastrong → created an issue.

aastrong → created an issue.

aastrong → made their first commit to this issue’s fork.

Hey guys, I have a much easier fix for the issues with the scrolling horizontally.
Try this instead:

html {
  overflow-x: hidden;
}

I dont want to change the padding on rows, containers or columns unless we need to
For the issues with the font size, your MR looks good.

This code was merged, closing ticket.

Tested and merged in, closing issue.

aastrong → created an issue.

This has been fixed and merged in.
Closing.

aastrong → created an issue.

MR is pushed, and will be reviewed shortly.

aastrong → created an issue.

Closing this and re-opening the one for simple menu.

aastrong → made their first commit to this issue’s fork.

Just following up,
There was some feedback and changes requested here:
https://www.drupal.org/project/projectapplications/issues/3376027 →

Cool beans !
Closing

@Luukyb

We dont commit the composer lock file for Provus, it gets created during the build process.
So i think this ticket is done and good to go.

Closing this issue, all fixed up, and merged in.

aastrong → made their first commit to this issue’s fork.

I've merged this in, closing issue now that ckeditor5 is the default.

Following while i look into this.
I have the same error.

Okay gotcha.
I honestly wasnt sure on the exact process or number of reviews to get things approved.
This is the first module that I personally was part of the process at all.

Im just commenting here to keep the ball rolling :)

Does this need further review before its accepted ?
Im one of the other maintainers, but i didnt do the work for this - just keeping an eye out for when its approved :)

Thanks everyone !

aastrong → created an issue.

Just commenting on this one.
I think this application can be closed, as I currently have no other projects needing this check.

But the other ticket,:
https://www.drupal.org/project/projectapplications/issues/3376027 →

Was created by kushan4157, and should remain open, and work done by him to resolve said issues.

Thanks All !

Hey there,
Thank you for creating the ticket !

There is still some work needed in order to pass the security advisory.
You can see here:
https://www.drupal.org/project/projectapplications/issues/3376027 →

You're the only person allowed to work on this, as you're the maintainer with the most commits in the project right now.
Is this something you're able to do ?

aastrong → created an issue.

aastrong → made their first commit to this issue’s fork.

This has been tested and merged.
Closing ticket.

This has been tested and merged.
Closing ticket.

aastrong → created an issue.

aastrong → created an issue.

aastrong → created an issue.

I don't think this has been fixed or touched yet.
Requires some config or template fixes - possibly some theming fixes.

So here is the plan for this to work.

#1. Setup logic in our twig template for all cards.
The logic follows as such

- If it is manual content
- If the link field is present
- If the link text is filled out ( show button, and make title and image clickable )
- If the link text is empty ( make entire card clickable )

MR is ready for review.

Going to review this and chat with the Provus team to see if we want to have this built in.
Seems good to me.

This looks good @_renify_

Can you please create a fork from this branch and create and MR based.
Than ill review everything and merge in.

@_renify_

We need 2 small changes.

1. The composer.json needs to have the module pinned to a specific version instead of
dropzone/dropzone": "^5.9",

Please see how the others have been done as well.

2. Can you please create a fork and create a MR with the patch applied, and i can review the MR.
If you need help doing that let me know.

As for the exact look and feel, we want to losely based it off of this screenshot.

aastrong → created an issue.

aastrong → created an issue.

aastrong → created an issue.