[8.x-2.x] Advanced Link Attributes

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

Fix PHPCS Issue.

vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,php  web/modules/contrib/ala/

FILE: /web/modules/contrib/ala/tests/src/Functional/LoadTest.php
----------------------------------------------------------------------------------------------
FOUND 19 ERRORS AFFECTING 19 LINES
----------------------------------------------------------------------------------------------
  1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
 14 | ERROR | [x] Opening brace should be on the same line as the declaration
 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 34 | ERROR | [x] Opening brace should be on the same line as the declaration
 35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 44 | ERROR | [x] Opening brace should be on the same line as the declaration
 45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 46 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 19 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------


FILE: /web/modules/contrib/ala/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 7 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------


FILE: /web/modules/contrib/ala/src/Form/ModuleConfigurationForm.php
-------------------------------------------------------------------------------------------------
FOUND 47 ERRORS AFFECTING 47 LINES
-------------------------------------------------------------------------------------------------
  1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
 12 | ERROR | [x] Opening brace should be on the same line as the declaration
 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 18 | ERROR | [x] Opening brace should be on the same line as the declaration
 19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 26 | ERROR | [x] Opening brace should be on the same line as the declaration
 27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 28 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 36 | ERROR | [x] Opening brace should be on the same line as the declaration
 37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 40 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 41 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 42 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 43 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 44 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 45 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 47 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 50 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 51 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 52 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 53 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 54 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 55 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 57 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
 59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 66 | ERROR | [x] Opening brace should be on the same line as the declaration
 67 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 79 | ERROR | [x] Opening brace should be on the same line as the declaration
 80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 81 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
 84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 47 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------


FILE: /web/modules/contrib/ala/src/Plugin/Field/FieldFormatter/AdvancedLinkAttributesFieldFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 161 ERRORS AND 3 WARNINGS AFFECTING 157 LINES
-------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  24 | ERROR   | [x] Opening brace should be on the same line as the declaration
  26 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  29 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  30 | ERROR   | [x] Opening brace should be on the same line as the declaration
  31 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  32 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  33 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  34 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  35 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  36 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  38 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  40 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  43 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  44 | ERROR   | [x] Opening brace should be on the same line as the declaration
  45 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  47 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  48 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  49 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  50 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  51 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  52 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  54 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  56 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  57 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  58 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  59 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  60 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  61 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  62 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  64 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  66 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  67 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  68 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  69 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  70 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  71 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  73 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  75 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  76 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  77 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  78 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  79 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  80 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  82 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  85 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  86 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  88 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  91 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  92 | ERROR   | [x] Opening brace should be on the same line as the declaration
  93 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  94 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  95 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  97 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  98 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  99 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 100 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 102 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 103 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 104 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 104 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 105 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 106 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 107 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 108 | ERROR   | [x] Object operator not indented correctly; expected 18 spaces but found 20
 108 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 109 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 111 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 112 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 113 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 113 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 113 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 114 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 116 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 117 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 119 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 120 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 121 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
 122 | ERROR   | [x] Line indented incorrectly; expected 12 spaces, found 24
 123 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
 124 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 125 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 127 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 128 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 129 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 131 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 132 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 133 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 16
 134 | ERROR   | [x] Line indented incorrectly; expected 12 spaces, found 20
 135 | ERROR   | [x] Line indented incorrectly; expected 14 spaces, found 20
 136 | ERROR   | [x] Line indented incorrectly; expected 16 spaces, found 24
 137 | ERROR   | [x] Case breaking statements must be followed by a single blank line
 137 | ERROR   | [x] Case breaking statement indented incorrectly; expected 22 spaces, found 24
 138 | ERROR   | [x] Line indented incorrectly; expected 14 spaces, found 20
 139 | ERROR   | [x] Line indented incorrectly; expected 16 spaces, found 24
 140 | ERROR   | [x] Case breaking statement indented incorrectly; expected 22 spaces, found 24
 141 | ERROR   | [x] Line indented incorrectly; expected 12 spaces, found 20
 142 | ERROR   | [x] Case breaking statement indented incorrectly; expected 18 spaces, found 20
 144 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 16
 145 | ERROR   | [x] Line indented incorrectly; expected 12 spaces, found 20
 146 | ERROR   | [x] Case breaking statement indented incorrectly; expected 18 spaces, found 20
 148 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 149 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 150 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 151 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 152 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 154 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 155 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 156 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 16
 157 | ERROR   | [x] Line indented incorrectly; expected 12 spaces, found 20
 158 | ERROR   | [x] Case breaking statement indented incorrectly; expected 18 spaces, found 20
 160 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 16
 161 | ERROR   | [x] Line indented incorrectly; expected 12 spaces, found 20
 162 | ERROR   | [x] Case breaking statement indented incorrectly; expected 18 spaces, found 20
 164 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 165 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 167 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 168 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 169 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 170 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 172 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 173 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 174 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 176 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 177 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 178 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 180 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 182 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 183 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 184 | ERROR   | [x] Array indentation error, expected 18 spaces but found 16
 187 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 188 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
 189 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
 190 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 191 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 192 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 194 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 195 | ERROR   | [x] Array indentation error, expected 18 spaces but found 16
 196 | ERROR   | [x] Array indentation error, expected 18 spaces but found 16
 197 | ERROR   | [x] Array indentation error, expected 18 spaces but found 16
 199 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 201 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 202 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
 203 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
 204 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
 204 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
 205 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
 205 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
 206 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
 207 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 208 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 210 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 211 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 212 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 213 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 214 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 215 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
 216 | ERROR   | [x] Line indented incorrectly; expected 12 spaces, found 24
 217 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
 218 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 219 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 220 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 222 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 223 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 161 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /web/modules/contrib/ala/src/Plugin/Field/FieldWidget/AdvancedLinkAttributesFieldWidget.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 136 ERRORS AND 1 WARNING AFFECTING 135 LINES
-------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  26 | ERROR   | [x] Opening brace should be on the same line as the declaration
  28 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  33 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  35 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  38 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  39 | ERROR   | [x] Opening brace should be on the same line as the declaration
  40 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  41 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  42 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  44 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  47 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  48 | ERROR   | [x] Opening brace should be on the same line as the declaration
  49 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  57 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  59 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  62 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  63 | ERROR   | [x] Opening brace should be on the same line as the declaration
  64 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  65 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  66 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  67 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  68 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  69 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  70 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  71 | ERROR   | [x] Array indentation error, expected 10 spaces but found 8
  73 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  75 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  80 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  81 | ERROR   | [x] Opening brace should be on the same line as the declaration
  82 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  84 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  85 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  87 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  90 | WARNING | [x] A comma should follow the last multiline array item. Found: false
  90 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  93 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  94 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  97 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  99 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 100 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 102 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 108 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 109 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 110 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 117 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 118 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 119 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 120 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 126 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 128 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 129 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 130 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 131 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 137 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 138 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 144 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 146 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 147 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 148 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 151 | ERROR   | [x] Line indented incorrectly; expected 12 spaces, found 16
 154 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 155 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 157 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 165 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 167 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 168 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 170 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 171 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 12
 172 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 16
 173 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 16
 174 | ERROR   | [x] Case breaking statement indented incorrectly; expected 14 spaces, found 16
 176 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 12
 177 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 16
 178 | ERROR   | [x] Case breaking statement indented incorrectly; expected 14 spaces, found 16
 180 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 12
 181 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 16
 182 | ERROR   | [x] Case breaking statement indented incorrectly; expected 14 spaces, found 16
 183 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 185 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 186 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 192 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 194 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 195 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 197 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 199 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 201 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 202 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
 203 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
 204 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
 209 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 210 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 211 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 213 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 214 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 216 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 221 | ERROR   | [x] Expected 1 spaces after parameter type; 36 found
 227 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 228 | ERROR   | [x] Opening brace should be on the same line as the declaration
 229 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 230 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 232 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 235 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 236 | ERROR   | [x] Opening brace should be on the same line as the declaration
 237 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 239 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 250 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 268 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 273 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 278 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 283 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 288 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 294 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 295 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 297 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 300 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 301 | ERROR   | [x] Opening brace should be on the same line as the declaration
 302 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 308 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 310 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 315 | ERROR   | [x] Expected 1 spaces after parameter type; 3 found
 321 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 321 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 322 | ERROR   | [x] Opening brace should be on the same line as the declaration
 323 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 324 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 325 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 327 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 328 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 329 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 330 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 331 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 333 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 334 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 335 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 336 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 337 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 137 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /web/modules/contrib/ala/ala.module
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------

As a reminder, the purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API, not what all the people who can commit on the project repository collectively understand about those points.

As comment #2 said, while this application is open, only the person who created the application can do commits in the project and the branch used for the application.

Thank you all, i have corrected phpcs issues.

Reviewed and No PHPCS issues found. Let's wait for other reviewers.

I don't see anything particularly bad with the code although, the dependency on jquery leads to unnecessary overhead and could improve the performance of page load if a pure javascript alternative was provided:

https://git.drupalcode.org/project/ala/-/blob/8.x-2.x/ala.libraries.yml#L6
https://git.drupalcode.org/project/ala/-/blob/8.x-2.x/js/color.js

That would be something that may prevent people from considering this module. I would encourage a pure javascript replacement to eliminate the library dependency.

@apmsooner Thank you for the suggestion!
Yes, Drupal core seems to move away from jQuery and contributed projects should follow that change too. Still, that is not a change that these applications can require because they focus on writing secure code that correctly uses the Drupal API and follows the Drupal coding standards.

Im just commenting here to keep the ball rolling :)

Does this need further review before its accepted ?
Im one of the other maintainers, but i didnt do the work for this - just keeping an eye out for when its approved :)

Thanks everyone !

@aastrong - I personally think the code is fine and should get out of this queue. I too have a module in for review and this process is a bit nonsensical if we're relying on the community for certain number of reviews and not getting them. There are alot of developers that got grandfathered into having this privileged role years ago that frankly write terrible code and release "stable" versions of modules that are broken. This badge only gives the community a sense of "security" that is often meaningless IMO but as maintainers we need it to get useage.

@apaderno, theres got to be a better way??

Okay gotcha.
I honestly wasnt sure on the exact process or number of reviews to get things approved.
This is the first module that I personally was part of the process at all.

No issues found
Changing status to RTBC!

• What follows is a quick review of the project; it doesn't mean to be complete
• For each point, the review usually shows some lines that should be fixed (except in the case the point is about the full content of a file); it doesn't show all the lines that need to be changed for the same reason
• A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; the single points aren't ordered, not even by importance

ala.module

  switch ($route_name) {
    case 'help.page.ala':
      $text = file_get_contents(__DIR__ . '/README.md');
      if (!\Drupal::moduleHandler()->moduleExists('markdown')) {
        return '<pre>' . Html::escape($text) . '</pre>';
      }
      else {
        // Use the Markdown filter to render the README.
        $filter_manager = \Drupal::service('plugin.manager.filter');
        $settings = \Drupal::configFactory()->get('markdown.settings')->getRawData();
        $config = ['settings' => $settings];
        $filter = $filter_manager->createInstance('markdown', $config);
        return $filter->process($text, 'en');
      }
  }
  return NULL;

The README.md file contains information that is not helpful when the module has been already installed, like the project page and the project queue links. The output is not translated and it is not even rendered as HTML markup, when the Markdown module is not installed.

/**
 * Implements template_preprocess_field().
 */
function ala_preprocess_field(&$variables) {
  if ($variables['field_type'] == 'link') {
    $element = $variables['element'];
    foreach ($element['#items'] as $delta => $item) {
      if (!empty($element[$delta]['#options']['parent_classes'])) {
        $variables['items'][$delta]['attributes']->setAttribute('class', $element[$delta]['#options']['parent_classes']);
      }
    }
  }
}

The correct documentation comment for that hook is Implements hook_preprocess_HOOK() for field templates.

/src/Plugin/Field/FieldFormatter/AdvancedLinkAttributesFieldFormatter.php

            switch ($settings['ala_link_view_icon_position']) {
              case "left":
                $link_title = Markup::create('<i class="' . $options['icon'] . '"></i>' . $link_title);
                break;

              case "right":
                $link_title = Markup::create($link_title . '<i class="' . $options['icon'] . '"></i>');
                break;
            }

The Markup class is a Drupal core internal class modules should never use. For generic markup, #markup, #theme, or #type should be used. It is also not clear why that class is used when its output is used for #plain_text.

src/Plugin/Field/FieldWidget/AdvancedLinkAttributesFieldWidget.php

  /**
   * {@inheritdoc}
   */
  public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, array $third_party_settings, EntityTypeManagerInterface $entity_type_manager) {
    parent::__construct($plugin_id, $plugin_definition, $field_definition, $settings, $third_party_settings);
    $this->entityTypeManager = $entity_type_manager;
  }

{@inheritdoc} is not used for constructors. The Drupal coding standards now say that documentation comment is not necessary; if it is added, it should given the same information given for a method that is not inherited from a parent class, excluding the description of the return value.

      $roles = $this->entityTypeManager->getStorage('user_role')->loadMultiple();
      $system_roles = array_map(
            function (RoleInterface $a) {
                return $a->label();
            }, $roles
        );

      $default_value = !empty($options['roles']) ? $options['roles'] : '';
      $element['options']['roles'] = [
        '#type' => 'select',
        '#multiple' => TRUE,
        '#title' => $this->t('Visible for'),
        '#options' => [
          'all' => $this->t('- Everyone -'),
          'authenticated' => $this->t('- Logged -'),
        ] + $system_roles,
        '#default_value' => $default_value,
      ];
    }

(As a side note) Since Drupal has a label for the authenticated users, why is not the code using that label?

        case 'global':
          $config = \Drupal::config('ala.settings');
          $classes_available = $this->getSelectOptions($config->get('ala_default_classes'));
          break;

All the dependencies must be injected with create().

I am changing priority as per Issue priorities → .

@kushan4157

Is this something you can look into ?
Since I am not one of the main contributors from the start, I cannot do these commits/fixes.

But I am more than willing to help with suggestions or patches.

1. FILE: ala.info.yml

core_version_requirement: ^8 || ^9 || ^10

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement → key.

2. FILE: ala.libraries.yml

version: VERSION

VERSION is only used by Drupal core modules. Contributed modules should use a literal string that does not change with the Drupal core version a site is using.

In case the previous comments have not been noticed: This application has been created by kushan4157 who is the only maintainer who can make commits for the project, until this application is not closed.

We do not review what all the project maintainers/co-maintainers collectively understand about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API.
This application is about kushan4157, not the project used in this application, even thought we use that project to check what kushan4157 understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API.

This thread has been idle, in the needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application. If you are no longer pursuing this application then I mark it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to set the issue status to Needs work or Needs review, depending on the current status of your code.

As a side note, kushan4157, who created this application, commented back only once, one year ago, which is exactly last time he logged in on drupal.org.

So I guess my question on this is.
At what point can I ( the other maintainer ), be able to submit for this application if the other developer is hasnt commented or doesnt have the time to push this forward ?

Id love to make what ever needed fixes, and get this approved by the security panel

At what point can I ( the other maintainer ), be able to submit for this application if the other developer is hasnt commented or doesnt have the time to push this forward ?

You cannot.
These applications are per person. Each person applies using a project where most of the commits (but preferably all the commits) in at least a branch have been done by that person.
They are not applications per projects, or we would just change the project status, instead of giving people a new Drupal role.