- Issue created by @aastrong
- 🇮🇳India shashank5563 New Delhi
Thank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.
- Status changed to Needs review
over 1 year ago 2:17am 15 May 2023 - 🇮🇳India vishal.kadam Mumbai
@shashank5563 Please don’t change the review branch set by applicant in the title.
- 🇮🇳India shashank5563 New Delhi
Fix PHPCS issue.
vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,php web/modules/ala/ FILE: /web/modules/ala/tests/src/Functional/LoadTest.php -------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" -------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------- FILE: /web/modules/ala/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 7 | WARNING | Line exceeds 80 characters; contains 81 characters ---------------------------------------------------------------------- FILE: /web/modules/ala/src/Form/ModuleConfigurationForm.php ----------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ----------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------- FILE: /web/modules/ala/src/Plugin/Field/FieldFormatter/AdvancedLinkAttributesFieldFormatter.php ----------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 133 | ERROR | [x] Case breaking statements must be followed by a single blank line ----------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------- FILE: /web/modules/ala/src/Plugin/Field/FieldWidget/AdvancedLinkAttributesFieldWidget.php ----------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 6 LINES ----------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 5 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 83 | ERROR | [x] Short array syntax must be used to define arrays 86 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE 93 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE 96 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines ----------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------- FILE: /web/modules/ala/ala.module ---------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ---------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------- - Status changed to Needs work
over 1 year ago 7:56am 15 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
For these applications, we need a project where, in at least the branch used for the application, most of the commits (if not all the commits) have been done from the user who applies.
The purpose of these applications is reviewing a project to understand what the user who applies understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API. A project without code committed by the user who applies cannot be used for these applications, especially when the user doesn't have the permission to commit code. - 🇮🇹Italy apaderno Brescia, 🇮🇹
There is not a 8.x-2.x branch; there is just a 8.x-1.x branch.
There are also wrongly named tags, since a tag created from a 8.x-1.x branch cannot be named 8.x-2.3. - Status changed to Needs review
over 1 year ago 5:48pm 16 May 2023 - 🇨🇦Canada aastrong
Hey everyone,
I've done a number of things to remediate the issues.1. I merged in the MR on the ALA to fix PHPCS issues.
2. I created a MR after running PHPCBF which fixed any remaining issues.
3. I had created a new branch for 8.x-2.x and merged all of these PR's in here
4. I than created a new tagged release based on the 8.x-2.x branch.I am modifying the title for the 2.x branch, as that is where my work has been done, and what I have set as the approved/recommended release.
Moving to needs review to have another look at this.
Please let me know if there is anything else missing. - Status changed to Needs work
over 1 year ago 7:21am 17 May 2023 - 🇮🇳India vishal.kadam Mumbai
Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ala FILE: ala/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 7 | WARNING | Line exceeds 80 characters; contains 81 characters ---------------------------------------------------------------------- FILE: ala/src/Form/ModuleConfigurationForm.php -------------------------------------------------------------------------------- FOUND 46 ERRORS AFFECTING 46 LINES -------------------------------------------------------------------------------- 12 | ERROR | [x] Opening brace should be on the same line as the declaration 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [x] Opening brace should be on the same line as the declaration 19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [x] Opening brace should be on the same line as the declaration 27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 28 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] Opening brace should be on the same line as the declaration 37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 40 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 41 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 42 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 43 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 44 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 45 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 47 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 50 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 51 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 52 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 53 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 54 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 55 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 57 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 66 | ERROR | [x] Opening brace should be on the same line as the declaration 67 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 79 | ERROR | [x] Opening brace should be on the same line as the declaration 80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 81 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12 84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 46 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ala/src/Plugin/Field/FieldFormatter/AdvancedLinkAttributesFieldFormatter.php -------------------------------------------------------------------------------- FOUND 160 ERRORS AND 3 WARNINGS AFFECTING 156 LINES -------------------------------------------------------------------------------- 24 | ERROR | [x] Opening brace should be on the same line as the declaration 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 30 | ERROR | [x] Opening brace should be on the same line as the declaration 31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 32 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 33 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 34 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 35 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 36 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 44 | ERROR | [x] Opening brace should be on the same line as the declaration 45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 48 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 49 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 50 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 51 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 52 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 54 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 56 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 57 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 58 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 59 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 60 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 61 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 62 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 64 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 66 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 67 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 68 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 69 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 70 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 71 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 73 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 75 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 76 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 77 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 78 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 79 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 80 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 82 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 92 | ERROR | [x] Opening brace should be on the same line as the declaration 93 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 94 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 97 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 98 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 99 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 100 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 102 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 103 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 104 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters 104 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 105 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 106 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 107 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 108 | ERROR | [x] Object operator not indented correctly; expected 18 spaces but found 20 108 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 109 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 111 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 112 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 113 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 113 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 113 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 114 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 116 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 117 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 119 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 120 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 121 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 122 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 123 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 124 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 125 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 127 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 128 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 129 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 131 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 132 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 133 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16 134 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 20 135 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 20 136 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 24 137 | ERROR | [x] Case breaking statements must be followed by a single blank line 137 | ERROR | [x] Case breaking statement indented incorrectly; expected 22 spaces, found 24 138 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 20 139 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 24 140 | ERROR | [x] Case breaking statement indented incorrectly; expected 22 spaces, found 24 141 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 20 142 | ERROR | [x] Case breaking statement indented incorrectly; expected 18 spaces, found 20 144 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16 145 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 20 146 | ERROR | [x] Case breaking statement indented incorrectly; expected 18 spaces, found 20 148 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 149 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 150 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 151 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 152 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 154 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 155 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 156 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16 157 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 20 158 | ERROR | [x] Case breaking statement indented incorrectly; expected 18 spaces, found 20 160 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16 161 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 20 162 | ERROR | [x] Case breaking statement indented incorrectly; expected 18 spaces, found 20 164 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 165 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 167 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 168 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 169 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 170 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 172 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 173 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 174 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 176 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 177 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 178 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 180 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 182 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 183 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 184 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 187 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 188 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 189 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 190 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 191 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 192 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 194 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 195 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 196 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 197 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 199 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 201 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 202 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 203 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 204 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters 204 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 205 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters 205 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 206 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 207 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 208 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 210 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 211 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 212 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 213 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 214 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 215 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 216 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 217 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 218 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 219 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 220 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 222 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 223 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 160 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ala/src/Plugin/Field/FieldWidget/AdvancedLinkAttributesFieldWidget.php -------------------------------------------------------------------------------- FOUND 113 ERRORS AND 1 WARNING AFFECTING 112 LINES -------------------------------------------------------------------------------- 26 | ERROR | [x] Opening brace should be on the same line as the declaration 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 39 | ERROR | [x] Opening brace should be on the same line as the declaration 40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 48 | ERROR | [x] Opening brace should be on the same line as the declaration 49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 63 | ERROR | [x] Opening brace should be on the same line as the declaration 64 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 65 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 66 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 67 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 68 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 69 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 70 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 71 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 81 | ERROR | [x] Opening brace should be on the same line as the declaration 82 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 90 | WARNING | [x] A comma should follow the last multiline array item. Found: false 90 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 94 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 97 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 100 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 109 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 110 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 119 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 120 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 129 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 130 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 131 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 137 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 138 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 147 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 148 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 154 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 155 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 157 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 170 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 172 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 173 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 174 | ERROR | [x] Case breaking statement indented incorrectly; expected 14 spaces, found 16 177 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 178 | ERROR | [x] Case breaking statement indented incorrectly; expected 14 spaces, found 16 181 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 182 | ERROR | [x] Case breaking statement indented incorrectly; expected 14 spaces, found 16 183 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 185 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 186 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 197 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 199 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 201 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 16 202 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 20 203 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 20 204 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 20 209 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 16 210 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 214 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 216 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 221 | ERROR | [x] Expected 1 spaces after parameter type; 36 found 227 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 228 | ERROR | [x] Opening brace should be on the same line as the declaration 229 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 230 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 232 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 235 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 236 | ERROR | [x] Opening brace should be on the same line as the declaration 237 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 239 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 250 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 268 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 273 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 278 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 283 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 288 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 294 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 295 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 297 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 300 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 301 | ERROR | [x] Opening brace should be on the same line as the declaration 302 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 308 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 310 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 315 | ERROR | [x] Expected 1 spaces after parameter type; 3 found 321 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 321 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 322 | ERROR | [x] Opening brace should be on the same line as the declaration 323 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 324 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 325 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 327 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 328 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 329 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 330 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 331 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 333 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 334 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 335 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 336 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 337 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 114 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ala/tests/src/Functional/LoadTest.php ------------------------------------------------------------------------------ FOUND 18 ERRORS AFFECTING 18 LINES ------------------------------------------------------------------------------ 14 | ERROR | [x] Opening brace should be on the same line as the declaration 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 34 | ERROR | [x] Opening brace should be on the same line as the declaration 35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 44 | ERROR | [x] Opening brace should be on the same line as the declaration 45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 46 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 ------------------------------------------------------------------------------ PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------ - 🇮🇹Italy apaderno Brescia, 🇮🇹
On the 8x-2.x branch there are 28 commits from Kushan Gunasinghe. What I reported for the other branch still holds true for this branch.
For these applications, we need a project where, in at least the branch used for the application, most of the commits (if not all the commits) have been done from the user who applies.
The purpose of these applications is reviewing a project to understand what the user who applies understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API, not what all the maintainers understand about those points. - Status changed to Closed: duplicate
over 1 year ago 4:07am 22 July 2023 - 🇮🇳India vinaymahale
Closing this as a duplicate of
https://www.drupal.org/project/projectapplications/issues/3376027 → - Status changed to Needs work
over 1 year ago 7:48am 22 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
@vinaymahale They are not duplicates, since they have been created from the same person. Yet, the same project cannot be used for two different applications. One of the applications needs to use a different project; it could also be both the applications need to use a different project.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
For these applications, we need a project where, in at least the branch used for the application, most of the commits (if not all the commits) have been done from the user who applies.
The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API, not what all the people who can commit on the project repository collectively understand about those points.In this case, most of the commits have been done by kushan4157. This application can continue only using a different project.
- Status changed to Closed: outdated
over 1 year ago 1:15pm 24 July 2023 - 🇨🇦Canada aastrong
Just commenting on this one.
I think this application can be closed, as I currently have no other projects needing this check.But the other ticket,:
https://www.drupal.org/project/projectapplications/issues/3376027 →Was created by kushan4157, and should remain open, and work done by him to resolve said issues.
Thanks All !