Automated Drupal 11 compatibility fixes for facets

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.3

claudiu.cristea → made their first commit to this issue’s fork.

What are the plans for the 3.0.x branch D11 compatibility?

Will at least the dev version be compatible soon?

So I guess, this leaves me no other option than to fork the module.

This is basically the last module that blocks me from upgrading to drupal 11.

Seems like the shortest path to a fix is to review and fix the patch.

mr219 looks like it applies, 227 has a conflict. It's not clear to me what the differences are or if the changes in 227 are good.

Were you able to test 219? Nobody has said anything about it yet, so maybe it works, or you could help clarify what the remaining issues are.

Looks like there are a lot of code quality issues that might be easy to resolve with some patience. That would also help speed this along.

If 219 works for you, you may as well run with it. If you hit any blockers, I'd encourage you to share patches here so we can all collaborate.

I applied 219 and it worked for me.
The only thing it missed is the core_version_requirement changes in the module, submodules and test modules.
core_version_requirement: ^10.1 || ^11.0

I can only do limited testing, but on my site using facets it worked fine.

But I would prefer not to use the lenient composer plugin, so any help pushing this forward is welcome.

Okay, so Merge request 227 works for me.
I rebased it, and added some more changes from the 2.x branch.

harika gujjula → made their first commit to this issue’s fork.

+1 for #13. Merge request 227 works for me too with the latest changes.
The failing tests seem to have a mix of minor fixable failures and dependency on other issues like https://www.drupal.org/project/drupal/issues/3230726 → . Fixed a few of them to move along.

The core_version_requirement can be removed from test modules, as long as the package is set to "Testing" in the .info.yml

See https://www.drupal.org/node/3070687 →

There are 2 competing MRs here. Can we close the one we aren't using any longer?

project-update-bot-only MR is only for the bot, and normally should have had no commits on it apart from that.

3455217-automated-drupal-11 MR !227 is the right MR, as you can see in #13

So what needs to be done here to consider for commit?

Do we need to fix all the tests in this issue even though the branch itself is not passing?

Or can this be committed, and then tests can be fixed in a follow up issue?