🇨🇦Canada @harika gujjula

+1 for #13. Merge request 227 works for me too with the latest changes.
The failing tests seem to have a mix of minor fixable failures and dependency on other issues like https://www.drupal.org/project/drupal/issues/3230726 → . Fixed a few of them to move along.

harika gujjula → made their first commit to this issue’s fork.

Released a new version 4.0 with all the changes captured.
Also added support for Drupal 11.

Thanks all for all your time.

Fixed along with https://www.drupal.org/project/dblog_filter/issues/3211112#comment-15506995 ✨ Complete Refactor - Filter on log message - Possible new version 4.x RTBC .

Perfect! Looks good now. Thanks for all your work.

@EduardoMoralesAlberti, Thanks for the work again.

Did you execute the module update? There is an update for this point, it takes the actual config on string format and transform it to booleans.

You were right. I missed to execute the update hook. Thanks. Now I see the config is saved, but the default values are not still populated on the form? And this is noticed with both dblog severity levels, syslog severity levels. Might have to just update #default_value as per the transformation from string to boolean ?

  $form['dblog']['severity_levels'] = [
      '#type' => 'checkboxes',
      '#title' => $this->t('Select Severity Levels'),
      '#description' => $severity_description,
      '#options' => $severity_levels,
      '#default_value' => $config->get('severity_levels') ?? [],
    ];

Minor Warnings noticed on Trait when log values are empty.
It is also possible that is related with the update, could you give us more information of the warnings? We could not reproduce it.

You were right again. This is due to the missing update hook. So, the cause for the warning earlier was due to the log_values config was of type string and foreach in LogTrait is throwing warnings. The log values is an array now after the update. This is now good.

Thank you for the description text updates too.

@Pasqualle, @EduardoMoralesAlberti, @tunic Thank you for all your thoughts and work on Refactoring this module. The patch seems to be good as per the pointers mentioned. But, Looks like there are few issues noticed with the merge request.

1. The form values does not appear to be saved for Db log Severity levels and syslog severity levels. This is because the type in Schema file is defined as boolean where it is expecting a string. Also accordingly update Schema and install files if necessary.
2. Minor Warnings noticed on Trait when log values are empty.
3. It would be good to include few readability changes alongside.
   • Update description text for "Enter DB Log type and Severity Levels" for both DBlog and Syslog to "Enter Log type and Severity Levels" on the Form.
   • Update help text for "Enter one value per line, in the format log_type|level1,level2,level3..|message to restrict the log messages stored, the message and the level are optionals." to "Enter one value per line, in the format log_type|level1,level2,level3..|message to limit the log messages stored, the message and the level are optionals."

harika gujjula → made their first commit to this issue’s fork.

harika gujjula → made their first commit to this issue’s fork.

This should be resolved as part of Duplicate of https://www.drupal.org/project/dblog_filter/issues/3358495 🐛 Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated RTBC

Thank you for the patch. This is now fixed.

harika gujjula → created an issue.