"Some" Pager Plugin and [view:total-rows] Regression Issue

Given there wasn't a lot of work involved, and to hopefully speed things along, I have created a MR with the proposed resolution.

Even though this should fix the related issues, it doesn't automatically close them as testing should be added for the specific bug experienced, ie visibility of the More link and how caching effects this visibility.

Believe there is also BC concerns to be had here as well. As this could immediately impact existing sites.

BC is definitely a consideration but I would consider it less so compared to the regression issues resulting from the change.

It would only impact sites that started using the [view:total-rows] token from version 10.1.0 because prior to that version it returned the total number of items before the pager limit was applied.

Similar to the token issue, we have a site where the usage of Displaying @current_record_count of @total on a block using the "Some" pager is now broken due to this change.

This is what it looked like from D8 all the way to D10.1.0

This is how it looks now

On further thought, on reading the issue summary of 🐛 [view:total-rows] problem in Display a 'Specified number of items' pager Postponed: needs info again, using @current_record_count in their header rather than [view:total-rows] would have solved their problem and there would have been no need for the code change.

So on further thought maybe the changes in 🐛 [view:total-rows] problem in Display a 'Specified number of items' pager Postponed: needs info should be rolled back and we instead update the description of [view:total-rows] token to explain it is the total number of items before any limiting by the page is applied.

Right now I am just proposing options, hoping to get feedback on preferred approach.

I have updated the Issue summary with the additional regression issue and the two possible resolutions I have thought of so far.

I have also added a MR for Option #1 which is now my preferred.

I have verified your changes, and its working as expected on Drupal version 11.x, here I attached the screen recording and screen shot.
Earlier it was not displaying "more" link when specified items are displaying.

Now it is working as expected.

Description also Updated

Updated title to also include Result Summary @total token.

Do not have an answer for the remaining tasks but the MR appears to need a manual rebase.

+1 for Option 1. I concur that the original fix in 🐛 [view:total-rows] problem in Display a 'Specified number of items' pager Postponed: needs info was flawed and seems to be tailored to a pretty rare use-case, where a Result Summary with @current_record_count could have simply been used. That change broke all the views on our site that use the pattern described in comment #6 → with a summary "displaying X of X" and a link to view all results. So while this change would break some backwards compatibility, it's also fixing backwards compatibility...

harika gujjula → made their first commit to this issue’s fork.