Layout shift on displays in views page

Created on 2 May 2024, 8 months ago
Updated 29 July 2024, 5 months ago

Problem/Motivation

There is a big layout shift on views page. There is a momentary flash of the no-javascript buttons before they are processed into the familiar Views UI.

Steps to reproduce

1. go to admin/structure/views/view/content page
2. See the Displays block
3. See the screenshot for reference.

Page's view page

Proposed resolution

These should probably just be hidden and exposed with a no-js stylesheet.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Fixed

Version

11.0 🔥

Component
Claro 

Last updated 2 days ago

Created by

🇮🇳India gauravvvv Delhi, India

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @gauravvvv
  • 🇮🇳India gauravvvv Delhi, India
  • 🇮🇳India gauravvvv Delhi, India
  • 🇮🇳India gauravvvv Delhi, India
  • 🇮🇳India gauravvvv Delhi, India
  • First commit to issue fork.
  • Status changed to Needs review 7 months ago
  • 🇮🇳India ahsannazir

    Not able to reproduce the issue. I have added screenshots for reference.
    Can you please add more details

  • Status changed to Needs work 7 months ago
  • 🇺🇸United States smustgrave

    Believe I can see the issue when the page refreshes. On the "Page" tab. Some weird janky shift.

  • 🇺🇸United States bnjmnm Ann Arbor, MI

    What @smustgrave spotted in #8 should probably be addressed - there is a momentary flash of the no-javascript buttons before they are processed into the familiar Views UI. These should probably just be hidden and exposed with a no-js stylesheet. Claro is already adding one here so you can build from that.

    The gif in the original issue summary looks like there are additional JavaScript errors as that gif shows clicking the "Add" button reloads the page. If JS is executing properly, that should not happen as the click event is prevented. If there is a JS error, however, the event handler that does this might not be getting added

  • Merge request !8082Issue #3444740: Layout shift on views tabs → (Closed) created by Unnamed author
  • Pipeline finished with Failed
    7 months ago
    Total: 181s
    #173052
  • Pipeline finished with Failed
    7 months ago
    Total: 178s
    #173143
  • Pipeline finished with Success
    7 months ago
    Total: 528s
    #173947
  • Status changed to Needs review 7 months ago
  • 🇮🇳India ahsannazir

    Thanks @bnjmnm for the suggestions. I have added the the no-script css and attached screen capture for reference

  • 🇮🇳India Kanchan Bhogade

    Hi
    I've tested MR !8082 on Drupal 11
    MR is applied successfully...

    The View Page is loading smoothly, without shifting the layout

    RTBC+1

    Adding recording for reference

    Keeping "needs review" for more reviews and code verification

  • Status changed to Needs work 7 months ago
  • 🇺🇸United States smustgrave

    Issue summary is still incomplete. Proposed solution is blank and should be filled in.

    As a UI change there should be a before/after screenshot or gif in this case if possible.

  • Status changed to Needs review 7 months ago
  • Status changed to RTBC 7 months ago
  • 🇺🇸United States smustgrave

    Tested out the solution and appears to not be there anymore. Not going to upload another set of screenshots :)

  • Status changed to Needs work 7 months ago
  • 🇫🇷France nod_ Lille

    few minor things

  • Status changed to Needs review 7 months ago
  • 🇮🇳India gauravvvv Delhi, India
  • Pipeline finished with Failed
    7 months ago
    Total: 997s
    #183713
  • Pipeline finished with Failed
    7 months ago
    Total: 899s
    #183750
  • Pipeline finished with Failed
    7 months ago
    Total: 967s
    #183755
  • Pipeline finished with Failed
    7 months ago
    Total: 635s
    #183762
  • Status changed to Needs work 7 months ago
  • 🇺🇸United States smustgrave

    Added some additional comments.

  • Pipeline finished with Success
    7 months ago
    Total: 668s
    #190407
  • Status changed to Needs review 7 months ago
  • Status changed to Needs work 7 months ago
  • 🇺🇸United States bnjmnm Ann Arbor, MI

    See MR

  • Pipeline finished with Success
    6 months ago
    Total: 511s
    #197996
  • Pipeline finished with Success
    6 months ago
    Total: 508s
    #198589
  • First commit to issue fork.
  • Status changed to Needs review 6 months ago
  • Rebased and also marking it needs review as all the feedbacks seems to be addressed.

  • Pipeline finished with Success
    6 months ago
    Total: 573s
    #218705
  • Status changed to RTBC 6 months ago
  • 🇺🇸United States smustgrave

    Verified changes to MR still address the "shift" when reloading a view page. Believe all feedback has been addressed.

  • Status changed to Needs work 5 months ago
  • 🇺🇸United States bnjmnm Ann Arbor, MI
  • Pipeline finished with Success
    5 months ago
    Total: 536s
    #221419
  • Status changed to Needs review 5 months ago
  • Pipeline finished with Success
    5 months ago
    Total: 546s
    #221511
  • Status changed to RTBC 5 months ago
  • 🇺🇸United States smustgrave

    Believe comment is better now, going to take the risk and mark it

    • nod_ committed e700aa81 on 11.x
      Issue #3444740 by ahsannazir, Utkarsh_33, Gauravvvv, Kanchan Bhogade,...
  • Status changed to Fixed 5 months ago
  • 🇫🇷France nod_ Lille

    Committed e700aa8 and pushed to 11.x. Thanks!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024