- Issue created by @gauravvvv
- First commit to issue fork.
- Status changed to Needs review
7 months ago 4:48am 14 May 2024 - 🇮🇳India ahsannazir
Not able to reproduce the issue. I have added screenshots for reference.
Can you please add more details - Status changed to Needs work
7 months ago 12:39pm 14 May 2024 - 🇺🇸United States smustgrave
Believe I can see the issue when the page refreshes. On the "Page" tab. Some weird janky shift.
- 🇺🇸United States bnjmnm Ann Arbor, MI
What @smustgrave spotted in #8 should probably be addressed - there is a momentary flash of the no-javascript buttons before they are processed into the familiar Views UI. These should probably just be hidden and exposed with a no-js stylesheet. Claro is already adding one here so you can build from that.
The gif in the original issue summary looks like there are additional JavaScript errors as that gif shows clicking the "Add" button reloads the page. If JS is executing properly, that should not happen as the click event is prevented. If there is a JS error, however, the event handler that does this might not be getting added
- Status changed to Needs review
7 months ago 4:39am 16 May 2024 - 🇮🇳India ahsannazir
Thanks @bnjmnm for the suggestions. I have added the the no-script css and attached screen capture for reference
- 🇮🇳India Kanchan Bhogade
Hi
I've tested MR !8082 on Drupal 11
MR is applied successfully...The View Page is loading smoothly, without shifting the layout
RTBC+1
Adding recording for reference
Keeping "needs review" for more reviews and code verification
- Status changed to Needs work
7 months ago 2:44pm 16 May 2024 - 🇺🇸United States smustgrave
Issue summary is still incomplete. Proposed solution is blank and should be filled in.
As a UI change there should be a before/after screenshot or gif in this case if possible.
- Status changed to Needs review
7 months ago 6:31am 23 May 2024 - Status changed to RTBC
7 months ago 6:26pm 24 May 2024 - 🇺🇸United States smustgrave
Tested out the solution and appears to not be there anymore. Not going to upload another set of screenshots :)
- Status changed to Needs work
7 months ago 2:17am 28 May 2024 - Status changed to Needs review
7 months ago 2:50am 28 May 2024 - Status changed to Needs work
7 months ago 2:02pm 3 June 2024 - Status changed to Needs review
7 months ago 6:01am 5 June 2024 - Status changed to Needs work
7 months ago 12:15pm 5 June 2024 - First commit to issue fork.
- Status changed to Needs review
6 months ago 8:58am 8 July 2024 Rebased and also marking it needs review as all the feedbacks seems to be addressed.
- Status changed to RTBC
6 months ago 1:57pm 8 July 2024 - 🇺🇸United States smustgrave
Verified changes to MR still address the "shift" when reloading a view page. Believe all feedback has been addressed.
- Status changed to Needs work
5 months ago 1:49am 11 July 2024 - Status changed to Needs review
5 months ago 7:33am 11 July 2024 - Status changed to RTBC
5 months ago 1:51pm 15 July 2024 - 🇺🇸United States smustgrave
Believe comment is better now, going to take the risk and mark it
- Status changed to Fixed
5 months ago 8:20pm 15 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.