- Issue created by @sidharth_soman
- Merge request !5977Required attribute added on storage wrappar label → (Open) created by Unnamed author
- Status changed to Needs review
about 1 year ago 4:20am 29 December 2023 - Assigned to Kanchan Bhogade
- Status changed to Needs work
about 1 year ago 5:59am 29 December 2023 - 🇮🇳India SandeepSingh199
Thanks for the patch @Gauravvvv, after applying the patch, it is focusing to that textbox but Error Message not showing.
- 🇮🇳India Kanchan Bhogade
Hi @Gauravvvv
I tested MR !5977 on Drupal version 11.0 for the Claro Theme
The patch was applied successfullyTesting Steps:
- Set up the Drupal 111.
- Set the Claro theme
- Go to -> structure ->Article content type -> Manage Fields -> Add the field
- Leave the label input empty. Choose a field type that displays additional options requiring you to scroll down below (for example, 'formatted text'). Choose any option and hit continue.
- Observed no focus on the empty label input.
- Apply the shared patch & reverify the results.
Test Result:
The patch was applied successfully, and the Error does not come into focus on the 'add fields' fixed;
But when the error comes into focus, the page scrolling is not up to the focus area.
Moving to Needs WorkThe video is attached for reference
Hi @Kanchan Bhogade,
It redirects to the label where needs to be focused or scrolled on validation. See the attached recording.
Thanks- Status changed to Needs review
about 1 year ago 12:56pm 2 January 2024 - Status changed to Needs work
about 1 year ago 2:35pm 2 January 2024 - Status changed to Needs review
about 1 year ago 9:34am 4 January 2024 - Issue was unassigned.
- Status changed to RTBC
about 1 year ago 10:53am 4 January 2024 - 🇮🇳India Kanchan Bhogade
Hi
I tested MR !5977 on Drupal version 11.0 for the Claro Theme
The patch was applied successfullyTesting Steps:
- Set up the Drupal 11.0.
- Set the Claro theme
- Go to -> structure ->Article content type -> Manage Fields -> Add the field
- Leave the label input empty. Choose a field type that displays additional options requiring you to scroll down below (for example, 'formatted text'). Choose any option and hit continue.
- Observed no focus on the empty label input.
- Apply the shared patch & reverify the results.
Test Result:
The patch was applied successfully, and the Error does not come into focus on the 'add fields' fixed;Moving to RTBC
Video for reference
- Status changed to Needs work
about 1 year ago 8:45am 21 February 2024 - 🇳🇿New Zealand quietone
There are failing tests. I am setting this to Needs work.
- 🇮🇳India niranjan_panem Gurugram
Checked in drupal 11 claro theme, not able to reproduce the issue.
below is the screen shot of foucs highlighting the empty label field. - 🇺🇸United States bnjmnm Ann Arbor, MI
re #16
Checked in drupal 11 claro theme, not able to reproduce the issue.
below is the screen shot of foucs highlighting the empty label field.You literally reproduced the issue. In your screenshot, the Text (plain) option is focused (notice the green outline), not the label field. While it's true the label field is red, it is not the focused element.
- 🇮🇳India niranjan_panem Gurugram
I don't think focus on empty label is an issue. Already we are displaying the error messages and highlighting the label with red color. Intuitively user get know what happened on that field.
- 🇺🇸United States bnjmnm Ann Arbor, MI
I don't think focus on empty label is an issue. Already we are displaying the error messages and highlighting the label with red color. Intuitively user get know what happened on that field.
It is an issue for non-sighted and other assistive tech users, and it is functionality that Drupal core provides in other forms.