New twig variable deprecation check should use a service and not the direct class

Patch attached

Tried to fixed the #2 issue.

If going to use patches an interdiff should be provided to show what you changed but one was not or an explanation.

Issue summary is missing proposed solution

Will need test coverage

Hello, I had the error

[error] 8924#8924: *155212268 FastCGI sent in stderr: "PHP message: Uncaught PHP Exception Twig\Error\RuntimeError: "The "Drupal\Core\Template\TwigExtension" extension is not enabled." at /home/XXXXX/www/web/themes/contrib/stable/templates/field/time.html.twig line 22"

after I upgraded Drupal to 10.2.1

And I fixed it with the attached patch, maybe it needs more testing.

I am using

"drupal/twig_extender": "5.1.0",
"drupal/twig_extender_extras": "5.1.0",

in my project.

Good luck.

I can confirm. The issue exists after update to Drupal 10.2.2 and when using "drupal/twig_extender": "5.1.0",

Confirmed, the patch in comment #6 fixes this issue for me. I am also running twig_extender → .

Updated summary with list of review tasks.

Replacing a extension sounds pretty dangerous.

The current approach of calling \Drupal::service is functional but seems like a _huge_ performance hit going to the container ever template render.

Does anyone know why the deprecation compiler code was written into the extension? It seems like it might have just been convenient.

If it was important, maybe we can move it to a dedicated "extension" that's not really an extension that just provides this helper?

If the approach isn't important, maybe we can just inline the check. Something like this maybe:

    $compiler->write("isset(\$context['deprecations']) && array_map(");
    $compiler->indent();
    $compiler->write("fn (\$name) =>");
    $compiler->indent();
    $compiler->write(
      "isset(\$context['deprecations'][\$name])",
      "&& \array_key_exists(\$name, \$context)",
      "&& @trigger_error(\$context['deprecations'][\$name], E_USER_DEPRECATED),"
    );
    $compiler->outdent();
    $compiler->subcompile($usedNamesNode);
    $compiler->outdent();
    $compiler->raw(");");

momow → changed the visibility of the branch 3409549-new-twig-variable to hidden.

This issue exists after drupal upgrade to 10.3.1 from 10.2.7
Patch 6 works for me

We upgraded from Drupal 10.1 to 10.2.7 and had a WSOD

Twig\Error\RuntimeError: The "Drupal\Core\Template\TwigExtension" extension is not enabled. in Twig\ExtensionSet->getExtension() (line 35 of docroot/core/themes/claro/templates/admin/admin-block-content.html.twig).

We also had an old version of twig_extender.

Applying the patch #6 and using twig_extender 5.1.0 works fine.

I created an MR with the #6 patch. I ran the PHPUnit test locally. It is working fine. I have attached a screenshot for your

@smustgrave hope issue summary is fine

Was also tagged for tests which are still needed.

I just tried upgrading to 10.3.6 and am now getting a WSOD. After some googling, I came across this thread (please let me know if it's best if I create a separate issue).

Currently, the error says Twig\Error\RuntimeError: The "Drupal\Core\Template\TwigExtension" extension is not enabled in "core/themes/claro/templates/classy/layout/html.html.twig". in /code/vendor/twig/twig/src/ExtensionSet.php on line 80

However, #6 would not apply for me because my TwigNodeCheckDeprecations.php already written that way.

I, too, am running Twig Extender.

The issue is that the extension is called by class name statically, For the twig_extender module users the extension called is different than the core one, So this patch get the class name from the service itself.

I haven't done heavy testing (but am no longer getting a WSOD!) but I used the second part of what alshami wrote in their patch to create one for 10.3.6.

There are two versions of the patch: one for the first patch alshami wrote and another for the second. This is the first.

Patch version #2 attached

The patch in comment #21 fixes this issue for me after upgrading from 10.3.5 to 10.3.6. I replaced patch at comment #6 with the new patch 3409549-21.patch
I am also running twig_extender.

Once again hit the error Twig\Error\RuntimeError: The "Drupal\Core\Template\TwigExtension" extension is not enabled (see #8) and I replaced the patch I was originally using in #6 with the patch provided in #21, which is working for me in 10.3.6 using twig_extender.

MR !9765 seems to be the closest to a fix of the two merge requests. The other MR breaks several tests. This MR only breaks one PHPUnit Unit test.

However it does not include a failing test, in fact a test is still required. Also the existing code needs fixed so it does not break any existing tests.

I tried to fix the TestCase issues but was unable to solve them. I am facing a problem with the test cases for the TWIG render function with arguments replaced.

Inside testFormatDate() $result = $twig->render('{{ time|format_date("html_date") }}', ['time' => $timestamp]);
and testFileUrl()$result = $twig->render('{{ file_url(file) }}', ['file' => 'public://picture.jpg']);.

But I checked by replacing the $compiler->write("\$this->env->getExtension(\\Drupal::service('twig.extension')::class)\n"); with $compiler->write("\$this->env->getExtension('\Drupal\Core\Template\TwigExtension')\n");, then the testcases are working fine.

Trying to solve by below ways on TwigNodeCheckDeprecations.php. But no luck,

1. $compiler->write("\$this->env->getExtension(\Drupal::service('twig.extension')::class)\n");
2. $compiler->write("\$this->env->getExtension(\\Drupal::service('twig.extension')::class)\n");
3. $compiler->write("\$this->env->getExtension(\\" . \Drupal::service('twig.extension')::class) . "\n");
3. $compiler->write("\$this->env->getExtension('\\" . \Drupal::service('twig.extension')::class) . "'\n");

oily → changed the visibility of the branch 3409549-twig-deprecation-check to hidden.

Hi @arunkumark, Which branch are you using for your code changes/ trials? I cannot see any commits?

We probably should hide the other (non-active) branch(es).

I'm using Drupal 10.3.10, and while patch #21(and others) fixes the fatal error on the site, the patch does not seem to fix the error when using Single-Directory Components module. (which will supposedly be a stable core module in D11)

@oily am using the 3409549-New-twig-variable-deprecation-check-should-use-a-service-and-not-the-direct-class branch and my MR 9765

Attached is #23 rerolled for core 10.4.x

Re-roll patch #23 for drupal 10.4.x.

Re-rolled the patch for Drupal Core 10.3.12

We are now using MR's instead of patches. The MR's are made against the 11.x branch and can then be back-ported to other versions.

rohitsharma401 → changed the visibility of the branch 3409549-New-twig-variable-deprecation-check-should-use-a-service-and-not-the-direct-class to hidden.

Patch for Drupal Core 10.4.x (added same changes to ComponentNodeVisitor)

Please ignore patches from #41
here's a patch that's against 10.4.x (added same changes to ComponentNodeVisitor)

SCD components not working after applying the patch

Twig\Error\RuntimeError: The "Drupal\Core\Template\TwigExtension" extension is not enabled in "theme:footer". in Twig\ExtensionSet->getExtension() (line 80 of /var/www/html/vendor/twig/twig/src/ExtensionSet.php).

#43 works on my setup. I'm now on 10.4.5

The error messages disappeared.

Thanks!