ui_patterns_settings.module - array_unshift()

Ahmad Abbad → made their first commit to this issue’s fork.

The hook_form_field_storage_config_edit_form_alter() is deprecated and should be replaced by hook_form_field_config_edit_form_alter().

I tried testing the fork ui_patterns_settings-3409221 and encountered this issue. After updating Drupal from 10.1.7 to 10.2 and replacing ui_patterns_settings with the proposed fork, the problem shifts to the core and returns the error: 'InvalidArgumentException: The configuration property settings.allowed_values.0.label.0 doesn't exist.' in Drupal\Core\Config\Schema\ArrayElement->get() (line 76 of core/lib/Drupal/Core/Config/Schema/ArrayElement.php). Installing Drupal 10.2 from scratch and using the fork instead of the official release doesn't change anything, or rather, the module doesn't throw an error, but the core does. It seems that someone else has reported this issue with the core.

I tested the fork as a patch on 10.2 and it fixed the issue for me.

It's worked for me too

It's worked for me too

Add inside "patches" section on composer.json files :

[...]
"drupal/ui_patterns_settings":{
    "[3409221] ui_patterns_settings.module - array_unshift()": "https://git.drupalcode.org/project/ui_patterns_settings/-/merge_requests/21.patch"
},
[...]

Yep, worked for me too. Thanks!

Works, but it the hook_ should be ui_patterns_settings_ rather than ui_patterns_ as that's this module's name (rather than the one it depends on).

It's worked for me, as show by #10
Thanks!

Another +1 for RTBC

Changing the hook from the one used in <=10.1 to one only present in 10.2+ is probably unwise, if the goal of this module is to support core versions other than latest stable. @Ahmad Abbad, can you specify in more detail how the deprecation causes the actual error? Deprecated methods and functions (and hooks) are just that, deprecations; they should not break anything but should work as reminders that a new implementation is needed in the longer run.

I have to take back my takeback. In Drupal 10.1 and below, the field configuration form and the field storage configuration form were two separate forms. In Drupal 10.2, the forms have been combined into one. Changing the hook this way would break the module when used with Drupal 10.1 (or below). If I'm reading the code correctly, changing the hook this way (from using form id field_storage_config_edit_form to using form id field_config_edit_form) would make the alterations move from the field storage config form to the field config form which is an entirely different thing in D10.1 and below. So then basically the submit function added in the hook, ui_patterns_settings_form_field_storage_config_edit_form_submit, will run on the field config rather than field storage config, meaning that the stored configuration would change, and most probably would not work correctly in other parts of the module anymore.

Based on the above I'm setting this back to Needs work. A solution should be found that works both on Drupal 10.1 and Drupal 10.2, at the very least, based on the project page's statement of supported major versions.

Drupal 10.1 EOL is slated for the Week of June 17, 2024.

If the new hook implementation is only needed on Drupal 10.2, and the old hook implementation is only needed on Drupal 10.1, then including them both, but returning early based on comparing against Drupal::VERSION, should work.

Hi,

Uploading patch for Composer usage.

This error prevents adding field on content entity types with Field UI on Core 10.2.

1. Restored the original hook for Drupal versions lower than 10.2.0
2. Added helper which determines whether we need the new hook or not
3. Renamed the original hook to _ui_patterns_field_form_alter, and aligned it a bit so it can work both on the old storage form and also on the new, combined form

Adding a traditional patch.

Addressed review feedback, asking for a next review.

Adding the usual traditional patch too.

I closed 🐛 Unhandled exception in function ui_patterns_settings_form_field_storage_config_edit_form_alter Closed: duplicate as a duplicate of this issue.
Please consider crediting people that worked over there.

Discussed with @Christian.wiedemann, I will try to check if both hooks can be preserved for backward compatibility instead of going to a hook_form_alter.

If not possible, we do a release then drop core 10.1 support in this issue.

New MR 27 ready for review.

@herved, https://www.drupal.org/u/herved → should also be credited. But as he only did code review in Gitlab, he is not appearing in the list.

Christian.wiedemann → credited herved → .

Thanks to all!

The new version will only be for drupal 10.2 or above

Automatically closed - issue fixed for 2 weeks with no activity.

Updating attribution

Thanks @DuaelFr for your mention. It was not done but not an issue for me. Most important : resolution