- Issue created by @kim.pepper
- last update
over 1 year ago 29,953 pass - @kimpepper opened merge request.
- Status changed to Needs review
over 1 year ago 12:16am 8 August 2023 - π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Re: #2 this contrib module exists, but seems like a trivial update to the status page that shouldn't require a contrib module to achieve.
- π³πΏNew Zealand RoSk0 Wellington
Thanks for raising this issue Kim.
But why only display? To me the warning when identifier is missing is the most important part of the DIS module, and I clearly failed to express this on the module project page and in the module messages.
I consider having deployment identifier set and changed with every version of the application being deployed is the best practice that community should follow and this module was my attempt to spread the word.
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
A lot of sites wouldn't need to use a deployment identifier. I don't think we should make it a warning. This might be something we could keep the contrib module for if you want this behaviour.
- Status changed to RTBC
over 1 year ago 2:41pm 9 August 2023 - πΊπΈUnited States smustgrave
Applied the MR and uncommented the line in settings.php
Verified I see the identifier on the status page
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
@RoSk0 if this gets into core, you could always do a
hook_requirements_alter()
and add a warning if there is no value set. 37:52 31:22 Running- π³πΏNew Zealand RoSk0 Wellington
About #6 Kim, how do you decide which website need that or not?
I saw bug reports for broken updates because contrib modules was changing service signatures, but never faced them myself. I'm convinced that deployment identifier is the answer to that.
Not arguing about getting this into core for sure - let's have this committed!
- last update
over 1 year ago 29,958 pass - last update
over 1 year ago 29,958 pass - last update
over 1 year ago 29,959 pass - last update
over 1 year ago 30,044 pass - last update
over 1 year ago 30,049 pass - last update
over 1 year ago 30,056 pass - last update
over 1 year ago 30,055 pass, 1 fail - last update
about 1 year ago 30,060 pass - last update
about 1 year ago 30,048 pass, 2 fail - last update
about 1 year ago 30,098 pass - last update
about 1 year ago 30,134 pass - last update
about 1 year ago 30,123 pass, 2 fail - last update
about 1 year ago 30,136 pass - last update
about 1 year ago 30,136 pass - π¬π§United Kingdom catch
I think we could consider using β¨ Create a new component: Toggletip RTBC to add information on where this can be configured if it's not set - as extra info rather than a warning? Tagging for follow-up to discuss that more.
- last update
about 1 year ago 30,146 pass - last update
about 1 year ago 30,148 pass - last update
about 1 year ago 30,150 pass - last update
about 1 year ago 30,161 pass - last update
about 1 year ago 30,161 pass - last update
about 1 year ago 30,168 pass - last update
about 1 year ago 30,168 pass 37:53 36:41 Running- last update
about 1 year ago 30,363 pass - last update
about 1 year ago 30,362 pass - last update
about 1 year ago 30,360 pass - last update
about 1 year ago 30,360 pass - last update
about 1 year ago 30,371 pass - last update
about 1 year ago 30,377 pass - last update
about 1 year ago 30,382 pass - last update
about 1 year ago 30,392 pass - last update
about 1 year ago 30,394 pass - last update
about 1 year ago 30,397 pass - last update
about 1 year ago 30,411 pass - last update
about 1 year ago 30,417 pass - last update
about 1 year ago 30,425 pass - last update
about 1 year ago 30,426 pass - last update
about 1 year ago 30,434 pass - last update
about 1 year ago 30,438 pass - last update
about 1 year ago 30,464 pass - last update
about 1 year ago 30,481 pass - last update
about 1 year ago 30,483 pass - last update
about 1 year ago 30,486 pass - last update
about 1 year ago 30,486 pass - last update
about 1 year ago 30,493 pass 22:52 14:11 Running-
longwave β
committed 47c383dd on 10.2.x
Issue #3379819 by kim.pepper, smustgrave, RoSk0: Display the...
-
longwave β
committed 47c383dd on 10.2.x
-
longwave β
committed 82032279 on 11.x
Issue #3379819 by kim.pepper, smustgrave, RoSk0: Display the...
-
longwave β
committed 82032279 on 11.x
- Status changed to Fixed
about 1 year ago 11:23pm 10 November 2023 - π¬π§United Kingdom longwave UK
Fixed the capitalisation issue on commit instead of holding this up further. As someone who uses deployment identifier in production I think this is a good idea and will only show on sites that use it anyway.
Committed and pushed 82032279d1 to 11.x and 47c383dd82 to 10.2.x. Thanks!
Feel free to open a followup to add a tooltip etc if you think this is a good idea.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
10 months ago 10:49am 22 January 2024 - π³πΏNew Zealand quietone
I created the followup, π Add a toggletip for deployment identifier information Active