- Issue created by @gauravvvv
- Status changed to Needs review
over 1 year ago 3:59am 16 June 2023 - last update
over 1 year ago Build Successful - 🇮🇳India gauravvvv Delhi, India
I have provided a patch to create footer promo block component. please review
- Status changed to Needs work
over 1 year ago 12:18pm 16 June 2023 - last update
over 1 year ago Build Successful - Status changed to Needs review
over 1 year ago 3:05am 20 June 2023 - last update
over 1 year ago 29,500 pass - 🇮🇳India gauravvvv Delhi, India
Fixed test failure. Attached interdiff for same. please review
- Status changed to Needs work
over 1 year ago 4:11pm 21 June 2023 - 🇺🇸United States smustgrave
Can the issue summary be updated as it references card view mode but that's not this ticket.
- Status changed to Needs review
over 1 year ago 3:23am 22 June 2023 - Status changed to RTBC
over 1 year ago 11:08pm 24 June 2023 - last update
over 1 year ago 29,554 pass - last update
over 1 year ago 29,560 pass - last update
over 1 year ago 29,564 pass 12:29 9:10 Running- last update
over 1 year ago 29,572 pass - last update
over 1 year ago 29,802 pass - last update
over 1 year ago 29,803 pass - last update
over 1 year ago 29,803 pass - last update
over 1 year ago 29,807 pass - Status changed to Needs work
over 1 year ago 4:03am 12 July 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 12:28pm 12 July 2023 - last update
over 1 year ago 29,812 pass - 🇮🇳India mrinalini9 New Delhi
Rerolled patch #5, please review it.
Thanks & Regards,
Mrinalini - Status changed to Needs work
over 1 year ago 3:21pm 12 July 2023 - 🇺🇸United States smustgrave
Can you please provide an interdiff + explanation for the additional changes?
Also not sure it should be moving things to demo_umami/components. See the theme folder, it has a components there.
- Status changed to Needs review
about 1 year ago 8:30am 3 September 2023 - 🇷🇸Serbia finnsky
Added common footer component for both blocks here:
https://www.drupal.org/project/drupal/issues/3368102#mr4695-note205072 ✨ Create new SDC component for Umami (umami common footer block) Fixed - 🇺🇸United States smustgrave
@finnsky are you saying you moved over work to another ticket? Should this be closed then.
- Status changed to Closed: duplicate
about 1 year ago 7:59pm 3 September 2023