Fix tests broken on PHP 8.3

Very probably this is a cause of CI which is unable to return results (I bet parsing fails for the same reason)

Ref https://dispatcher.drupalci.org/job/drupal_patches/187212

05:25:02 Drupal\Tests\system\FunctionalJavascript\ModuleFilterTest      1 passes                                      
05:25:11 Drupal\Tests\media\FunctionalJavascript\MediaEmbedFilterConf  22 passes                                      
05:25:32 Build timed out (after 110 minutes). Marking the build as aborted.
05:25:53 Build was aborted
06:40:22 Archiving artifacts
06:40:22 /opt/drupalci/testrunner/jenkins.sh: line 36: 32704 Terminated

I bet it's critical

New failures from https://www.drupal.org/pift-ci-job/2693255 →

Testing Drupal\Tests\migrate_drupal_ui\Functional\d6\Upgrade6TestWithContentModeration
E                                                                   1 / 1 (100%)

Time: 00:19.494, Memory: 4.00 MB

There was 1 error:

1) Drupal\Tests\migrate_drupal_ui\Functional\d6\Upgrade6TestWithContentModeration::testUpgradeAndIncremental
LogicException: Missing bundle entity, entity type node_type, entity id forum.

/var/www/html/core/lib/Drupal/Core/Entity/EntityType.php:877
/var/www/html/core/modules/content_moderation/src/Plugin/WorkflowType/ContentModeration.php:241
/var/www/html/core/lib/Drupal/Core/Plugin/PluginDependencyTrait.php:71
/var/www/html/core/lib/Drupal/Core/Plugin/PluginDependencyTrait.php:89
/var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:381
/var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:321
/var/www/html/core/modules/workflows/src/Entity/Workflow.php:114
/var/www/html/core/lib/Drupal/Core/Entity/EntityStorageBase.php:528
/var/www/html/core/lib/Drupal/Core/Entity/EntityStorageBase.php:483
/var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:257
/var/www/html/core/lib/Drupal/Core/Entity/EntityBase.php:339
/var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:609
/var/www/html/core/modules/migrate_drupal_ui/tests/src/Functional/d6/Upgrade6TestWithContentModeration.php:48
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

ERRORS!
Tests: 1, Assertions: 8, Errors: 1.

.......

Testing Drupal\Tests\migrate_drupal_ui\Functional\d7\Upgrade7TestWithContentModeration
E                                                                   1 / 1 (100%)

Time: 00:21.898, Memory: 4.00 MB

There was 1 error:

1) Drupal\Tests\migrate_drupal_ui\Functional\d7\Upgrade7TestWithContentModeration::testUpgradeAndIncremental
LogicException: Missing bundle entity, entity type node_type, entity id forum.

/var/www/html/core/lib/Drupal/Core/Entity/EntityType.php:877
/var/www/html/core/modules/content_moderation/src/Plugin/WorkflowType/ContentModeration.php:241
/var/www/html/core/lib/Drupal/Core/Plugin/PluginDependencyTrait.php:71
/var/www/html/core/lib/Drupal/Core/Plugin/PluginDependencyTrait.php:89
/var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:381
/var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:321
/var/www/html/core/modules/workflows/src/Entity/Workflow.php:114
/var/www/html/core/lib/Drupal/Core/Entity/EntityStorageBase.php:528
/var/www/html/core/lib/Drupal/Core/Entity/EntityStorageBase.php:483
/var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:257
/var/www/html/core/lib/Drupal/Core/Entity/EntityBase.php:339
/var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:609
/var/www/html/core/modules/migrate_drupal_ui/tests/src/Functional/d7/Upgrade7TestWithContentModeration.php:48
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

ERRORS!
Tests: 1, Assertions: 7, Errors: 1.

@andypost #4 was caused by ✨ Mark an entity as 'syncing' during a migration update Needs work , this is now reverted.

Reported upstream with simplified script https://github.com/php/php-src/issues/11469

The cause is https://github.com/php/php-src/commit/50fdad83256989fadcb92e584ef77ef80d...

The commit was reverted, waiting for next alpha https://github.com/php/php-src/commit/ad5ee8a2b7ad960ba8286d11ff98d53098...

The proposed BC code is https://github.com/php/php-src/issues/11469#issuecomment-1597866217

function setNodeValue($attrNode, $value) {
    $attrNode->nodeValue = '';
    $attrNode->appendChild(new \DOMText($value));
}

I added a a more specific workaround to the issue fork.

@tstarling please create a MR from the issue fork, I did approve your account

Queued suggested fix
- mysql https://www.drupal.org/pift-ci-job/2696385 →
- sqlite https://www.drupal.org/pift-ci-job/2696386 →

Tests are passed now but parsing artifacts fails, so this fix is not enough to allow CI to complete

03:09:24 Drupal\Tests\media\FunctionalJavascript\MediaEmbedFilterConf  22 passes                                      
03:10:06 Build timed out (after 110 minutes). Marking the build as aborted.
03:10:09 Build was aborted
04:26:16 Archiving artifacts
04:26:16 /opt/drupalci/testrunner/jenkins.sh: line 36:  3720 Terminated              ./drupalci run /var/lib/drupalci/workspace/builds/build.yml

This log means tests are stuck on parsing results

Since the tests are still failing.

Looking at logs I see that parser fails on new tests that were not executed, ref #[3346765]

PHP Notice: Undefined index: Drupal\Tests\system\FunctionalJavaScript\NoJavaScriptAnonymousTest in /opt/drupalci/testrunner/src/DrupalCI/Build/Artifact/Junit/JunitXmlBuilder.php on line 82

Composer namespaces are case sensitive

Locally unable to reproduce but on runner it hangs finishing simpletest_script_execute_batch() probably some process hangs

still hangs, probably some test result parsing stucks

The test Drupal\Tests\file\FunctionalJavascript\MaximumFileSizeExceededUploadTest is missing in ci-run

skip it now

updated IS

@andypost, have you been able to run these tests locally with PHP 8.3-alpha2 and compared the results vs the d.o ci ?

@joseph.olstad yes, the same test hangs even after replacing Apache with nginx-unit

strace shows something strange to me

reverted IS fix

@andypost does that trace happen before or during the file upload, ie. in

    $page->attachFileToField("files[field_file_0]", $this->fileSystem->realpath($invalid_file));

Maybe there is a new bug in PHP 8.3 when post_max_size is exceeded? There are some changes around stack overflow handling and perhaps some changes around out of memory conditions as well: https://stitcher.io/blog/new-in-php-83#stack-overflow-detection-pr

It's caused by generateFile() which is very slow with each iteration but no before https://3v4l.org/WciJK#v8.2.7

Reported upstream https://github.com/php/php-src/issues/11507

Filed child to improve the test 📌 Fix MaximumFileSizeExceededUploadTest test for PHP 8.3 Fixed

updated IS

Fixed via https://github.com/php/php-src/commit/3c872661c13a2543c28e1ce27ebd53876f...

As of my last update in September 2021, PHP 8.3 has not been released yet. However, I can provide you with some general guidelines to fix tests that may break when moving from PHP 8.2 (or an earlier version) to PHP 8.3. Keep in mind that these are speculative, and you should consult the official PHP documentation and release notes for PHP 8.3 for accurate information when it becomes available.

Update Dependencies: Make sure all your dependencies, including testing frameworks and libraries, are compatible with PHP 8.3. Check for updates on their respective GitHub repositories or websites.

Check for Deprecated Features: PHP 8.3 might deprecate certain functions or features that were available in earlier versions. Search for deprecated features in your codebase and replace them with recommended alternatives.

Review Error Reporting: PHP 8.3 may introduce stricter error reporting settings. Ensure that your tests handle errors and exceptions correctly. Avoid relying on outdated error suppression techniques like the @ symbol.

Type Declarations: PHP 8.3 could introduce new type declarations or modify existing ones. Review all type declarations in your tests and ensure they align with the changes in PHP 8.3.

Static Analysis: Use static analysis tools like PHPStan or Psalm to identify potential issues and bugs in your code. These tools can catch errors that might not be apparent during normal testing.

Test Case Assertions: Review all your test case assertions to ensure they remain valid in PHP 8.3. Certain edge cases or changes in internal behaviors could lead to test failures.

Testing Extensions: If your tests rely on PHP extensions, verify that these extensions are compatible with PHP 8.3. Some extensions might need updates to work correctly.

Array Syntax: PHP 8.3 might introduce changes to array syntax or array functions. Review your codebase for any array-related issues.

Regex Changes: If your tests utilize regular expressions, be aware of any regex changes in PHP 8.3. Adjust your patterns as needed.

Build a Testing Matrix: Set up a testing matrix with various PHP versions, including PHP 8.3, to run your tests. This way, you can quickly identify issues that are specific to PHP 8.3.

Always remember to test your code thoroughly after making any changes. Automated tests, continuous integration, and good test coverage are essential for detecting issues early in the development process. Additionally, keep an eye on the official PHP releases and update your code accordingly when PHP 8.3 is officially released.

@shiv_tech chatgpt is not helpful here yet

Deleted comment #40 by user shiv_tech → .

It was obviously AI generated content and served no useful purpose.

New failure on beta3 #3375693-27: Fix deprecated assert_options() function usage for PHP 8.3 →

Looks this failure is caused by libxml version

Filed new issue for that 📌 TextSummaryTest:testLength() fails on some libxml versions Closed: outdated

As 📌 Fix deprecated assert_options() function usage for PHP 8.3 Needs review commited, all tests are pass, any new regressions could use new issues with PHP 8.3 tag

andypost → closed merge request !4214