- Issue created by @andypost
- last update
about 1 year ago CI error - Status changed to Needs review
about 1 year ago 8:58am 25 June 2023 - last update
about 1 year ago 1 pass - last update
about 1 year ago 1 fail - 🇫🇷France andypost
fixed patches, probably needs follow-up to use new Random PHP core extension
- last update
about 1 year ago 1 fail The last submitted patch, 4: 3368789-4-optimized.patch, failed testing. View results →
- last update
about 1 year ago 1 fail - last update
about 1 year ago 1 fail The last submitted patch, 6: 3368789-5.patch, failed testing. View results →
- last update
about 1 year ago 1 pass - last update
about 1 year ago 1 pass - 🇫🇷France andypost
So test now running 15-16 seconds instead of 42
The only usage of
generateFile()
is leftcore/modules/file/tests/src/Functional/FileFieldDisplayTest.php:63: $this->generateFile('escaped-&-text', 64, 10, 'text'); core/modules/file/tests/src/FunctionalJavascript/MaximumFileSizeExceededUploadTest.php:122: $valid_file = $this->generateFile('not_exceeding_post_max_size', 8, 8);
- 🇫🇷France andypost
There's not a big usage in contrib http://codcontrib.hank.vps-private.net/search?text=generateFile%28&filen...
- 🇫🇷France andypost
Filed follow-up 📌 Deprecate TestFileCreationTrait::generateFile() Active
- last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago 29,554 pass - last update
about 1 year ago 29,554 pass - last update
about 1 year ago 29,553 pass, 1 fail - last update
about 1 year ago 29,553 pass, 1 fail - last update
about 1 year ago 29,554 pass - 🇫🇷France andypost
It require to write something to the end of file to keep size
- last update
about 1 year ago 29,554 pass The last submitted patch, 16: 3368789-16.patch, failed testing. View results →
- Status changed to RTBC
about 1 year ago 4:40pm 26 June 2023 - Status changed to Fixed
about 1 year ago 1:51pm 27 June 2023 - 🇬🇧United Kingdom catch
@andypost has opened 📌 Deprecate TestFileCreationTrait::generateFile() Active to see if we can get rid of ::generateFile() altogether.
Changes here look good, it's five lines instead of one but it's pretty self-explanatory.
Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!
- 🇫🇷France andypost
Thank you!
Now waiting someone to re-queue
- https://www.drupal.org/pift-ci-job/2692079 →
- https://www.drupal.org/pift-ci-job/2691057 → Automatically closed - issue fixed for 2 weeks with no activity.