Fix MaximumFileSizeExceededUploadTest test for PHP 8.3

let's measure perf

and optimizer one

fixed patches, probably needs follow-up to use new Random PHP core extension

The last submitted patch, 4: 3368789-4-optimized.patch, failed testing. View results →

The last submitted patch, 6: 3368789-5.patch, failed testing. View results →

So test now running 15-16 seconds instead of 42

The only usage of generateFile() is left

core/modules/file/tests/src/Functional/FileFieldDisplayTest.php:63:    $this->generateFile('escaped-&-text', 64, 10, 'text');
core/modules/file/tests/src/FunctionalJavascript/MaximumFileSizeExceededUploadTest.php:122:    $valid_file = $this->generateFile('not_exceeding_post_max_size', 8, 8);

There's not a big usage in contrib http://codcontrib.hank.vps-private.net/search?text=generateFile%28&filen...

Filed follow-up 📌 Deprecate TestFileCreationTrait::generateFile() Active

Final patch

proper title

Fix dictionary

Fix CS

Looks there's no reason to use random at all

It require to write something to the end of file to keep size

The last submitted patch, 16: 3368789-16.patch, failed testing. View results →

All green !

@andypost has opened 📌 Deprecate TestFileCreationTrait::generateFile() Active to see if we can get rid of ::generateFile() altogether.

Changes here look good, it's five lines instead of one but it's pretty self-explanatory.

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

Thank you!

Now waiting someone to re-queue

- https://www.drupal.org/pift-ci-job/2692079 →
- https://www.drupal.org/pift-ci-job/2691057 →

Automatically closed - issue fixed for 2 weeks with no activity.