Add [#\ReturnTypeWillChange] attribute to TemporaryArrayObjectThrowingExceptions for PHP 8.3 compatibility

Other files are not affected, script to check find core -name '*.php' -exec php -l {} \; >/dev/null

Baseline test runs

- 10.1 https://www.drupal.org/pift-ci-job/2691058 →
- 11.0 https://www.drupal.org/pift-ci-job/2691057 →

Only 2 tests failed comparing to 118 in base run

Test 'Drupal\Tests\filter\Kernel\FilterKernelTest::testCaptionFilter' ended

Failed asserting that two strings are identical.
Expected :'<img data-caption="This is a &lt;a href=&quot;https://www.drupal.org&quot;&gt;quick&lt;/a&gt; test…" src="llama.jpg" />'
Actual   :'<img data-caption="This is a &amp;lt;a href=&amp;quot;https://www.drupal.org&amp;quot;&amp;gt;quick&amp;lt;/a&amp;gt; test…" src="llama.jpg" />'

which means & escaped twice

Test 'Drupal\Tests\editor\Unit\EditorXssFilter\StandardTest::testFilterXss with data set #190 ('<img src="butterfly.jpg" data...t;" />', '<img src="butterfly.jpg" data...t;" />')' ended

Failed asserting that two strings are identical.
Expected :'<img src="butterfly.jpg" data-caption="&amp;lt;script&amp;gt;alert();&amp;lt;/script&amp;gt;" />'
Actual   :'<img src="butterfly.jpg" data-caption="&amp;amp;lt;script&amp;amp;gt;alert();&amp;amp;lt;/script&amp;amp;gt;" />'

the same

Looks OK to me.

I did wonder if we should just change the return types here, and perhaps make the class final, but that can be done in a followup so we can discuss it.

Committed/pushed to 11.x and 10.1.x, thanks!

@longwave Sadly we can't add true type hint as it was added in 8.2 https://wiki.php.net/rfc/true-type

Example of using bool on 8.1

/srv # php -v
PHP 8.1.20 (cli) (built: Jun  7 2023 09:47:40) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.20, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.20, Copyright (c), by Zend Technologies

/srv # php core/modules/jsonapi/src/Normalizer/Value/TemporaryArrayObjectThrowingExceptions.php
PHP Fatal error:  Cannot use 'Drupal\jsonapi\Normalizer\Value\true' as class name as it is reserved in /srv/core/modules/jsonapi/src/Normalizer/Value/TemporaryArrayObjectThrowingExceptions.php on line 158

Fatal error: Cannot use 'Drupal\jsonapi\Normalizer\Value\true' as class name as it is reserved in /srv/core/modules/jsonapi/src/Normalizer/Value/TemporaryArrayObjectThrowingExceptions.php on line 158

Filed follow-up for #6

sorry

Ahh thanks @andypost, I did not know that true was only PHP 8.2+.

Automatically closed - issue fixed for 2 weeks with no activity.