[2.0.4] Fix the issues reported by phpcs

Hi, Here is the patch. Please review.

Thanks!

Reviewed! After applying patch #2 all errors seems to be fixed.

Hello arpitk,
I have reviewed your patch & Implemented it on my website having version 9.5.9 And PHP version - 8.1
I am adding some screenshots(before/after applying the patch) for your reference).
Please have a look once at these screenshots. And Thank You.

The report shows errors/warning for six files, but the patch changes only four files.

Providing patch with fixes.

-- Don't understand a rules or don't know how to implement it? No problem click on its link,
- you will be redirected to our where you will find all the information you need to set it up.
+- Don't understand a rules or don't know how to implement it? No problem click
+    on its link, you will be redirected to our where you will find all the
+    information you need to set it up.

The lines after the first one are indented two spaces more than needed.

-    '#help' => t('This checklist is based on the rules of Opquast\'s standards.') . $licence_link->toString(),
+    '#help' => t("This checklist is based on the rules of Opquast\'s standards.") . $licence_link->toString(),

Since the string delimiter has been changed, there is no need to escape the single quotes inside the string.

 /**
- * Class OpquastService
+ * OpquastService class to provide services.
  */
-class OpquastService
-{
+class OpquastService {

A class description must not repeat the class name. to provides services is a too broad description.

+  /**
+   * {@inheritdoc}
+   */
+  public function __construct(LanguageManagerInterface $languageManager) {
+    $this->languageManager = $languageManager;
+  }

The description for a constructor must start with Constructs a new followed by the class name (including its namespace), and end with object.

+  /**
+   * Function detect current language and return base path of rules.
+   *
+   * If not exist return english language.

A method description must not start with Function or Method.
The used verbs must be declined to the third person singular.
The longer description is not necessary and it is not grammatically correct.

    * @param string $path
+   *   Path variable or url.

url is misspelled, since it is an acronym.
It is not necessary to say variable and Path or URL. is too broad; at least it should say which path is passed to the method.

   * @return string
+   *   Output will be string.

The return value type is already reported in the @return line; the description must describe what is returned.

    * Function return licence path of opquast website.
    *
    * @return string
+   *   Output will be string.
    */
-  public function getLicencePath(): string
-  {
+  public function getLicencePath(): string {

   /**
    * Function return endpoint url of opquast website.
+   *
    * @return string
+   *   Output will be string.
    */
-  public function getApiEndPoint(): string
-  {
+  public function getApiEndPoint(): string {

Since that documentation comment is changed, also the description must be changed.
The return value description is wrong for the same reason given before.

Addressed #7.
Updated patch.

Providing interdiff file for #9

Hello Folks !!
Tested the #2 patch for opquast_checklist 2.0.3 on Drupal 9.5.9 and PHP 8.2, Got some phcs errors .

Later applied the # 9 patch using composer version 2.5. Couldn't apply patch!
I will be adding both screenshot for references.

Thank you.

The patch must be used with the 2.0.x branch, not a tagged release. With that branch, the patch applies.

Anyway, running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig I get 18 errors and 6 warnings. It seems the report shown in the issue summary is not complete.

   /**
-   * Function detect current language and return base path of rules. If not exist return english language.
+   * Constructs a new OpquastService instance.
+   *

The class name is missing its namespace.

+  /**
+   * Detect current language and return base path of rules.
+   *
+   * If not exist return english language.
    *
    * @param string $path
+   *   The opquast checklist path.
+   *
    * @return string
+   *   The base URL of rules.

The verbs used in the description must be inflected in the third person singular.
base path of rules should be rules base path.
If not exist return english language. is not grammatically correct, and it must be changed to If it does not exist, returns the English language. It still not clear to what it does not exist is referring, though.
The return value is not the base URL, but the base path.

-   * Function return endpoint url of opquast website.
+   * Get endpoint url of opquast website.

url is misspelled, since it is an acronym.

Addressed #16. Updated patch.

phpcs fixes.

Hello everyone,
Thanks for the feedback and the associated patch.
I've gone back to patch 20 and fixed the latest PHPCS problems.
@aparderno I've also taken your feedback into account.

I've credited you all and I'm sorry for the lack of feedback over the last few months!
Marc