🇷🇪Réunion @Martygraphie

Hi @ktpm,
thank you for this issue! I downloaded the module yesterday and set it up with Gemini, I'm having the same problem, the prompt entered in the provider is not supported!

Your patch works very well for me!

Thanks

Hi @leontin,
I merged your patch and credited you directly in this issue : https://www.drupal.org/project/geomap_field/issues/3430747 📌 Automated Drupal 11 compatibility fixes for geomap_field Needs review
Thanks !

Marc

Hi @tim-diels
Will you be able to check the patch?
Thank you in advance
Marc

martygraphie → changed the visibility of the branch 3449679-add-attributes-specifics-routes-to-link to active.

martygraphie → changed the visibility of the branch 3449679-add-attributes-specifics-routes-to-link to hidden.

the_g_bomb → credited Martygraphie → .

I confirm that patch #3446896 correctly displays the number of results. I close this issue.

Martygraphie → made their first commit to this issue’s fork.

Martygraphie → made their first commit to this issue’s fork.

Luke.Leber → credited Martygraphie → .

Hello,
I'm also reproducing the problem in version 3.x.
If I understand correctly the problem / solution proposed by @veronicaSeveryn
I proposed a fix following feedback from @veronicaSeveryn. Which only adds Domain entity URL generator when creating the variant. I'm not aware of the impact on other features.

Martygraphie → made their first commit to this issue’s fork.

Martygraphie → created an issue.

I've created a new issue #3449679 , I'm closing this one again

Martygraphie → created an issue.

Hello,
I'm still having problems with this approach:

1. Tokens ( and returns an empty url with the approach $item[‘url’]->toString(); , which is annoying because you can no longer distinguish between elements.
2. Attributes defined for links in the administration space are not retrieved (e.g. class).

@pdureau, should I create a new isssue?

Hi,
Works fine !
Thanks

Hi,
Suggestion: I've realised that you can set up a project using the input.html.twig template, which will surely be easier to read: https://git.drupalcode.org/project/ui_suite_dsfr/-/blob/1.0.x/templates/... and use the Twig removeAttribute function.

Example: {{ children }}

Martygraphie → created an issue.

Martygraphie → created an issue.

Martygraphie → created an issue.

Thanks, the fix is available in 1.0.3.

Martygraphie → made their first commit to this issue’s fork.

Martygraphie → created an issue.

Hello,
I'd like to add your code to the dedicated html tags to make them easier to read

Martygraphie → created an issue.

And i've also added a conditional checking that the domain logo configuration exists before attempting to delete it.
I'll let you tell me if it's right for you.

Marc

Hi,
I've tested the domain site module, and I can confirm that not all domain-related configurations have been deleted.
The reason is that the domain site delete form tries to delete the configuration instead of the domain entity. Some modules use the deletion of the entity to delete the other configurations.

Proposed solution:
Delete entity directly instead of the configuration.
This will automatically delete the following configurations: actions, simple sitemap, domain menus and the domain record.
I'm going to propose a merge request.

Marc

Martygraphie → made their first commit to this issue’s fork.

Hello,
Thank you all for your work, I credit everyone for your work.

Hello,
I confirm @smustgrave's last comment.
I can't apply the patch in MR #6, but if I retrieve the image and add it manually to the folder it works too.

I prefer the iframe.png image in comment #12, which is more explicit than the image in MR.

Apologise, this was caused by an external script that doesn't belong to config ignore, so I'm closing the exit.

Hi,
I am reopening this issue, I reproduce the same error on the ^3.2 version of config ignore. With steps similar to those described initially.

Drupal version: 10.1
Drush version: 11

I also tried with and without config_filter (lats version)

I'm adding a temporary patch so that the modification will work on version 1.0.0-beta4 (based on version 1.9 of the DSFR)

Hi Pierre,
Yes, good idea, I've updated my commit,
I'll let you check
Have a nice day

Martygraphie → created an issue.

I'm adding a temporary patch to make this branch work with this issue: #3410309.

Martygraphie → created an issue.

Hi,
Thanks @corentin.crouvisier
Patch #18 works for me !

Just a warning for users of the paragraphs_features or paragraphs_ee module: the change breaks the rendering of the quick-add buttons between paragraphs.

Before :

After :

But this will surely be addressed in the modules concerned once this fix has been validated.

Martygraphie → created an issue.

Martygraphie → created an issue.

Hello,
Thanks for the patch and the treatment, I've just noticed that it hasn't been released.
It will be available in version 2.0.4
Have a nice day

Hello everyone,
Thanks for the feedback and the associated patch.
I've gone back to patch 20 and fixed the latest PHPCS problems.
@aparderno I've also taken your feedback into account.

I've credited you all and I'm sorry for the lack of feedback over the last few months!
Marc

Martygraphie → created an issue.

Hi,
Thanks for your patch !

I forgot to passed in need review !

Martygraphie → created an issue.

Martygraphie → created an issue.

Hi @benjifisher,
Thank you very much for your analysis, I've encountered the same problem as you.
Deactivating ALT / TITLE attributes solved the performance problems on my side.
Marc

Hi @igor-mashevskyi,
Patch #7 works fine for me.
Thanks !