martygraphie → created an issue.
Hello,
I apologize. I didn't realize that I had the Editor Advanced Link module enabled. It does indeed appear to be a duplicate.
Thank you for your analysis and sorry for the time spent.
Have a nice day.
martygraphie → created an issue.
Hi,
I’m also experiencing this issue, which completely breaks the CKEditor toolbar.
Environment details:
- PHP 8.3
- Drupal 10.5
- ckeditor_iframe module version 3.0.0-beta3
Observed behavior:
The CKEditor toolbar fails to load when the ckeditor_iframe plugin is included in the text format configuration (in my case, Full HTML). As soon as I remove the plugin from the toolbar configuration, the editor displays correctly again.
JS error in the browser console:
ckeditor5.js?sy59yr:467 TypeError: Cannot read properties of undefined (reading 'check')
at new o (iframeembed.js?sy59yr:1:6331)
at s._createFormView (iframeembed.js?sy59yr:1:8658)
at s.init (iframeembed.js?sy59yr:1:7771)
I'm attaching a screenshot showing how the formatted text field looks with the plugin active under the Full HTML format.
Marc
Hi @saschaeggi,
I find this quite unfortunate.
Your approach enables a modern solution without relying on two separate modules (Layout Builder and Navigation). However, since I don’t use the Layout Builder module in my projects, I find it burdensome to enable such a complex module just to manage an admin toolbar.
I’m taking the liberty of submitting my patch, which addresses all the related points.....
Marc
martygraphie → created an issue.
Hi,
This patch adds support for the is_button indicator on link (links) objects.
The goal is to allow templates especially within navigation components to easily detect when a <button>
type route should be rendered as a <button>
HTML element.
It might not be the most elegant solution, but it's simple and functional.
Example usage in a TWIG template of component:
{% if item.is_button %}
<button{{ item.link_attributes }}>
{{ item.title }}
</button>
{% endif %}
Marc
Hi,
I confirm this is working now.
Thank you for your analysis. This will indeed help other maintainers understand why their module isn’t showing up in project browser.
Sincerely,
Marc
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
Sorry, I was on version 1.3 and this has been corrected on the dev version.
I close the issue
martygraphie → created an issue.
MR works fine ! Thanks.
I no longer see alerts.
Marc
MR works fine !
I no longer see alerts.
Marc
Hi,
Patch #16, works fine !
Marc
martygraphie → created an issue.
Review and merged thanks !
Merged thanks !
Merged thanks !
Thanks merged !
Merged thanks
Merged, thanks !
Hi @doxigo,
There's still the stylelint job, which I think may have more or less impact. Would you look into this? (I'm not the most knowledgeable on this subject)
I recommend that you test the update following the .module update (normally no impact).
Source : https://git.drupalcode.org/issue/gin_gutenberg-3509129/-/jobs/4500720
Marc
martygraphie → created an issue.
Hi @jhuhta
I fixed cspell and added the dependencies (drupal/ai and drupal/key) in composer.json this will strengthen version management and allow PHPStan to perform the audit as a whole)
I let you test and tell me if ok for you
Marc
Hello,
Yes ok, I'll create a new issue
Hi @doxigo,
Sorry, I forgot to draft the MR, the pipeline passes but there is still warning phpcs, cspell, stylelint
Marc
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
Hi @just_like_good_vibes
I may have misspoken, I was talking about the table in the Drupal page and not the README. I'd like to update the page but I don't have access to edit it, which is reserved for the module maintainer.
Hello @chandansha
Could you modify your MR to target the 2.0.x branch which is the one used by the module?
Thanks
Marc
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
martygraphie → created an issue.
Hi,
I creating a merge request to make tracking easier. I made the necessary modifications and also replaced the default pictogram with a rounded version, which will be more consistent with the other icons in the project (link to the free pictogram: https://www.iconpacks.net/free-icon/bluesky-blue-round-circle-logo-24461...). I placed Bluesky below Twitter in the admin form for better coherence (as suggested by @s3b0un3t).
Marc
martygraphie → made their first commit to this issue’s fork.
Hi,
Patch #4 works fine !
Thanks !
Hi @ktpm,
thank you for this issue! I downloaded the module yesterday and set it up with Gemini, I'm having the same problem, the prompt entered in the provider is not supported!
Your patch works very well for me!
Thanks
Hi @leontin,
I merged your patch and credited you directly in this issue :
https://www.drupal.org/project/geomap_field/issues/3430747
📌
Automated Drupal 11 compatibility fixes for geomap_field
Needs review
Thanks !
Marc
Hi @tim-diels
Will you be able to check the patch?
Thank you in advance
Marc
martygraphie → changed the visibility of the branch 3449679-add-attributes-specifics-routes-to-link to active.
martygraphie → changed the visibility of the branch 3449679-add-attributes-specifics-routes-to-link to hidden.
the_g_bomb → credited Martygraphie → .
I confirm that patch #3446896 correctly displays the number of results. I close this issue.