Drop ES5 transpilation

Open on Drupal.org →

Created on 1 July 2024, 4 months ago

Updated 20 August 2024, about 2 months ago

Problem/Motivation

Presently, the build dependencies of this module are very out of date. The latest version of node that can build the assets is Node 10. This is inherently insecure for anyone wishing to develop this module further.

Now that the latest release doesn't support Drupal 9, there are no remaining blockers.

Proposed resolution

Eliminate the build step entirely. Drupal core no longer supports ES5. There is no longer a need for a build step at all.

Remaining tasks

Remove build step.
Test
Commit
Release

User interface changes

None

API changes

None

Data model changes

None

📌 Task

Status

Needs review

Version

2.0

Component

Code

Created by

🇺🇸United States luke.leber Pennsylvania

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!16Drop ES5 transpilation
Open
🇺🇸United States luke.leber
updated 3 months ago

Comments & Activities

Issue created by @luke.leber
Comment 4 months ago →
🇺🇸United States luke.leber Pennsylvania
Status changed to Postponed 4 months ago2:45pm 1 July 2024
Comment 4 months ago →
🇺🇸United States luke.leber Pennsylvania
Postponed on https://www.drupal.org/project/media_library_form_element/issues/3432301 📌 Request to remove build dependencies in stable releases Needs review
Status changed to Active 3 months ago12:37am 2 August 2024
Comment 3 months ago →
🇺🇸United States luke.leber Pennsylvania
Comment 3 months ago →
🇺🇸United States mark_fullmer Tucson
Luke.Leber → credited mark_fullmer → .
Comment 3 months ago →
🇮🇳India sreeram_v Hyderabad
Luke.Leber → credited sreeram_v → .
Comment 3 months ago →
🇺🇸United States luke.leber Pennsylvania
Transferring issue credits from https://www.drupal.org/project/media_library_form_element/issues/3432301 📌 Request to remove build dependencies in stable releases Needs review
Status changed to Needs review 3 months ago1:18am 2 August 2024
Comment 3 months ago →
🇺🇸United States luke.leber Pennsylvania
I am mobile now and had a bit this evening to myself. Trying to move this issue along.

I've simply moved the ES6 asset in place of the ES5 and deleted the build stuff. Hope to be able to test against a real site soon, unless someone beats me to it 🙏.
Merge request !16Resolve #3458296 "Completely remove build step" → (Open) created by luke.leber
Comment 3 months ago →
🇳🇱Netherlands heine
Luke.Leber → credited Heine → .
Comment 3 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Luke.Leber → credited larowlan → .
Comment 3 months ago →
🇷🇪Réunion Martygraphie Saint-Denis (Réunion)
Luke.Leber → credited Martygraphie → .
Comment 3 months ago →
🇺🇸United States luke.leber Pennsylvania
Adding missing issue credits from security.drupal.org
Comment about 2 months ago →
🇺🇸United States mark_fullmer Tucson

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024