Actions and sitemap not deleted when deleting a domain site

Created on 9 May 2023, about 1 year ago
Updated 5 April 2024, 3 months ago

Problem/Motivation

When deleting a domain site, the actions and simple_sitemap are not deleted.

Steps to reproduce

Create a site
Delete a site
Do a config import and see validation errors

Proposed resolution

Fix the problem

Remaining tasks

Create patch

User interface changes

-

API changes

-

Data model changes

-

🐛 Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

🇧🇪Belgium tim-diels Belgium 🇧🇪

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @tim-diels
  • First commit to issue fork.
  • 🇷🇪Réunion Martygraphie Saint-Denis (Réunion)

    Hi,
    I've tested the domain site module, and I can confirm that not all domain-related configurations have been deleted.
    The reason is that the domain site delete form tries to delete the configuration instead of the domain entity. Some modules use the deletion of the entity to delete the other configurations.

    Proposed solution:
    Delete entity directly instead of the configuration.
    This will automatically delete the following configurations: actions, simple sitemap, domain menus and the domain record.
    I'm going to propose a merge request.

    Marc

  • Status changed to Needs review 3 months ago
  • 🇷🇪Réunion Martygraphie Saint-Denis (Réunion)

    And i've also added a conditional checking that the domain logo configuration exists before attempting to delete it.
    I'll let you tell me if it's right for you.

    Marc

Production build 0.69.0 2024