Deprecate ::supportedInterfaceOrClass property on normalizer/denormalizers

I bet it needs to convert and clean-up all usages in core

here's a different approach - removal of property definition and throwing deprecation message

It could use existing change record https://www.drupal.org/node/3359695 → as the method now more useful

But maybe it should use parent method implementation (from Symfony)

fix cs

Updated IS a bit

Fix few tests

fix cs

Fix last tests

Hi applied succesfully in drupal 11.x version
Tests are passing
Deprecations are corrects (deprecation message follows the required patters)
Property has been removed has issue's summary says

Moving to RTBC

Committed/pushed to 11.x, thanks!

I thought about backporting this to 10.1.x but I don't think the late deprecation after beta will particularly help anyone.

Not seeing the push yet?

Also unsure if this needs a change record as per the tag?

I've added this issue to https://www.drupal.org/node/3359695 → but I don't think we need a separate one.

I think it needs follow-up to remove other mentions in code-comments

Thanks @andypost. I've opened 📌 Remove remaining occurences of ::supportedInterfaceOrClass property Fixed for that.

I was (pleasantly!) surprised to already see this land due to its BC break implications … but I see it landed only in 11.x! 🤯 Will this not be a problem for 10.2!

- Deprecation warning is on 10.2 in the 11.x branch
- The 10.2.x branch will be branched from 11.x branch at the time of 10.2.0-alpha1, so that will "inherit"the deprecation.

I think we're good.

Yes this will be in 10.2.

I do wonder if we should consider backporting this bit (and the similar ones) to 10.1, without the deprecation message, so that contrib modules can start to use it as soon as they drop support for 10.0 and 9.5:

+++ b/core/modules/serialization/src/Normalizer/NormalizerBase.php
@@ -37,7 +30,13 @@ public function supportsNormalization($data, string $format = NULL, array $conte
 
-    $supported = (array) $this->supportedInterfaceOrClass;
+    if (property_exists($this, 'supportedInterfaceOrClass')) {
+      @trigger_error('Defining ' . static::class . '::supportedInterfaceOrClass property is deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Use getSupportedTypes() instead. See https://www.drupal.org/node/3359695', E_USER_DEPRECATED);
+      $supported = (array) $this->supportedInterfaceOrClass;
+    }
+    else {
+      $supported = array_keys($this->getSupportedTypes($format));
+    }

Moving back to 'to be ported' in case people agree.

Here's patch #12 but without deprecation

TestBot is unhappy about the 9.5.x patch :/

The patch is for 10.1 which has SF 6.3 and can benefit from the change, 9.5 I triggered just for fun

Thanks @andypost, I was already wondering about SF 6.3 and 9.5.x.

Also, we had a few escapees (See 📌 Add missing ::hasCacheableSupportsMethod deprecations Closed: outdated ), may we should get those in first and then do the backport?

Good idea to combine backport with polishing, we can include 📌 Remove remaining occurences of ::supportedInterfaceOrClass property Fixed

So marking as the tests seem green. Change record appears to cover what's happening too.

Committed f3d4f1b and pushed to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

I'd like to add some information to the change record. I got hit with a deprecation that referenced the change record associated with this issue.

https://git.drupalcode.org/project/rest_views/-/commit/69d089ef7794badda...

The change record did not seem to address this case. I'd propose updating the title to something like:

Normalizers/Denormalizers should implement ::getSupportedTypes() instead of ::hasCacheableSupportsMethod() or using protected $supportedInterfaceOrClass

Then in the change record showing a before and after:

Before

  /**
   * The interface or class that this Normalizer supports.
   *
   * @var array
   */
  protected $supportedInterfaceOrClass = [RenderableData::class];

After

  /**
   * {@inheritdoc}
   */
  public function getSupportedTypes(?string $format): array {
    return [
      RenderableData::class => TRUE,
    ];
  }