Enable bundle selection when a new view mode is created

Posted some feedback in the MR ✌️

If I try to edit a view mode, I'm getting following error:

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition() (line 139 of core/lib/Drupal/Core/Entity/EntityTypeManager.php).
Drupal\field_ui\Form\EntityDisplayModeFormBase->form(Array, Object) (Line: 106)
Drupal\Core\Entity\EntityForm->buildForm(Array, Object)
call_user_func_array(Array, Array) (Line: 536)
Drupal\Core\Form\FormBuilder->retrieveForm('entity_view_mode_edit_form', Object) (Line: 283)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object) (Line: 39)
Drupal\layout_builder\Controller\LayoutBuilderHtmlEntityFormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 583)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 163)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 74)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 53)
Asm89\Stack\Cors->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 698)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

I really like this change, good idea! Since the form where this is being added is not really packed, I would recommend adding a description to the options field explaining that the form will still be available for the rest of the bundles, but not enabled. Hopefully things like this description can be hidden in the future behind an "info" Tooltip ( ✨ Create a new component: Toggletip RTBC ) and simplify some UIs.

Added the description.

Random failure in InstallerExistingConfigMultilingualTest, mentioned here #2829040-170: [meta] Known intermittent, random, and environment-specific test failures →

@Utkarsh_33 Reviewed and left some feedback

Random test failures same as mentioned in #11.

Some UI tweaks needed.

Addressed feedbacks.

Think this introduces a usability issue.

There's a button under each entity type but also still "Add view mode" at the top. Isn't clear which is to be used or the differences between the two.

Thanks for the feedback @smustgrave! I agree that it might not be ideal that we have multiple different ways to achieve the same task. FWIW, the links are pre-existing. However, this issue styles the links to look like buttons because they are rendered using modal dialogs. We are planning to continue working on this UI so maybe that's something we should look into in our next iteration.

We did run this by 12 users and we didn't discover any usability issues related to having multiple buttons on the page. According to Nielsen Norman, with that number of users, we can be fairly confident that most users are able to use this UI as it was tested.

What if you just remove the main button?

I'm open to trying that. If I recall correctly, the usage between the button on the top and the buttons on the list was roughly 50/50. I'd be happy to include that in a future round of interviews. I'm wondering if based on #20 we could work on that separately from this issue, or do you feel strongly that it's a blocker for this issue?

Never want to be the blocker haha

But it was confusing and I had to test both buttons to see if there were any differences. Maybe minimum there could be some text to say they’re the same

Do you think that's made worse by this issue? I guess if it's made worse by this issue, we could remove the button styles from the links pointing to adding a view mode to an individual view mode.

Not sure which one would be better. But having the individual buttons under the entity type is a very nice touch.

Discussed with @smustgrave at DrupalCon and we decided to split the feedback regarding multiple buttons into a follow-up issue: 🐛 Duplicate "Add view mode" buttons RTBC .

As mentioned discussed this at DrupalCon and seems good.

It looks like the checkboxes on edit form are not working as expected. The checkboxes are not showing if the view mode is enabled for the bundle. It also looks like disabling view modes is not possible through the edit form.

I'll be working on this one today.

I've updated the issue summary with before / after screenshots.

As well, I've fixed editing existing view modes and added support for deleting view displays when unchecking the bundle.

Just talked to Laurii; we're going to convert the edit form to be a dialog as a part of this issue too.

Removed the role=button and tabindex=0 for now because we're planning to handle that in 📌 Add role="button" and spacebar trigger to to behave like a button Active .

This change is implemented on both display modes (Form & View), but everywhere in MR 'View mode' is mentioned, not sure if this is correct or not.

Also getting below error while trying to add new Form mode:
Uncaught PHP Exception Error: "Call to a member function getConfigDependencyName() on null" at ...EntityDisplayBase.php line 300, referer: .../admin/structure/display-modes/form

We should add test coverage for the form modes. We could probably use Drupal\Tests\field_ui\FunctionalJavascript\ ViewModeBundleSelectionTest as a starting point.

Done changes for form mode, added test.

Threads appear to be resolved.

Also retested on 11.x

Created a "Content" view mode using the new button.
Selected only Articles and not Basic page
Confirmed the view mode was added to just Articles

Used the old method of adding a view mode
Selected only Basic page
Confirmed view mode was added to just Basic page.

Thank you everyone for working on this! 🙏 This is starting to look really solid! Few more comments on the MR and then I think we're done 😊

Retested following #41 and seems to be working as expected.

Checked recent commits and the issue seems still RTBC to me.

Committed 381c38a and pushed to 11.x. Thanks! See you in 🌱 [Plan] Improve field creation experience Active . 👋

lauriii → closed merge request !3971

🤩

This is awesome to see land! and in such short time. Truly shows the power of the community.

Automatically closed - issue fixed for 2 weeks with no activity.