Drupal 10 compatibility

This patch should have the correct versions for the core_version_requirement.

And this patch has the fixed, along with the .

Looks good to me. This will drop Drupal 8 compatibility, but it is not supported anymore anyway.

Is further testing required, or is this good to go?

Looking at the merge request, you are removing the twig/extensions requirement and then adding the twig/twig requirement. But shouldn't it be the other way around?
Otherwise it doesn't change any code other than the required Drupal versions which should be fine. Twig has already been updated for D10 so this should be mergeable.

I've also looked into the library that it fetches from twig/extensions. although this repo hasn't been updated in about 3 years the code doesn't seem to have any PHP deprecations with PHP 8.1 which is a requirement for D10. But it does state in that composer.json file that it needs: "php": "^7.1.3". But it doesn't seem to create a problem when fetching the libraries.

When can we expect a stable release for d10 compatibility of this module?

After updating tho this Fork in order to have D10 compatibility, I'm facing this error when trying to clear the cache.

Service 'twig_extensions.twig.array' for consumer 'twig' does not implement Twig\Extension\ExtensionInterface.

Backing tho the latest release version, the error stops. Any help with that?

I also get this after updating to this Fork for D10:

Service 'twig_extensions.twig.array' for consumer 'twig' does not implement Twig\Extension\ExtensionInterface.

But I can't get rid of it reverting the module :O

Based on everyone saying this doesn't work, switching back to needs work.

paucala → closed merge request !4

Sorry, i tried some commits but dosen't work either...

chetan 11 → made their first commit to this issue’s fork.

I can't even get past drupal-lenient to apply this patch (https://git.drupalcode.org/project/twig_extensions/-/merge_requests/3.patch).

composer require drupal/twig_extensions:2.x-dev@dev -W

outputs...

Problem 1
    - twig/extensions[v1.3.0, ..., v1.4.1] require twig/twig ~1.20|~2.0 -> found twig/twig[v1.20.0, ..., 1.x-dev, v2.0.0, ..., 2.x-dev] but these were not loaded, likely because it conflicts with another require.
    - twig/extensions[v1.5.0, ..., 1.x-dev] require twig/twig ^1.27|^2.0 -> found twig/twig[v1.27.0, ..., 1.x-dev, v2.0.0, ..., 2.x-dev] but these were not loaded, likely because it conflicts with another require.
    - drupal/twig_extensions 2.x-dev is an alias of drupal/twig_extensions dev-2.x and thus requires it to be installed too.
    - drupal/twig_extensions dev-2.x requires twig/extensions ^1.3 -> satisfiable by twig/extensions[v1.3.0, ..., 1.x-dev].
    - Root composer.json requires drupal/twig_extensions 2.x-dev@dev -> satisfiable by drupal/twig_extensions[2.x-dev (alias of dev-2.x)].

Would this be resolved if the commit was merged?

Was able to composer require
fin composer require 'drupal/twig_extensions:2.x-dev@dev'
and than add the latest merge request for patching
uploading here for other people to link to (safer than the original patch URL)

NOTE: the patch has nothing new and applies cleanly on latest dev

This did not work after all
ended up with this after upgrading to drupal 10.1

$ fin composer update
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - twig/twig[v2.0.0, ..., v2.12.5] require php ^7.0 -> your php version (8.1.21) does not satisfy that requirement.
    - Root composer.json requires drupal/core-recommended 10.1.6 -> satisfiable by drupal/core-recommended[10.1.6].
    - twig/extensions[v1.5.4, ..., 1.x-dev] require twig/twig ^1.27|^2.0 -> satisfiable by twig/twig[v1.27.0, ..., 1.x-dev, v2.0.0, ..., 2.x-dev].
    - You can only install one version of a package, so only one of these can be installed: twig/twig[v1.16.0, ..., 1.x-dev, v2.0.0, ..., 2.x-dev, v3.0.0-BETA1, ..., 3.x-dev].
    - drupal/core-recommended 10.1.6 requires twig/twig ~v3.6.0 -> satisfiable by twig/twig[v3.6.0, v3.6.1].
    - Root composer.json requires twig/extensions ^1.5.4 -> satisfiable by twig/extensions[v1.5.4, 1.x-dev].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Yeah, looks like unless someone pushes changes to dev and tests, module will be problematic.

Yes, not working for me too, patch should be merged. Really stuck here drupal-lenient not helped

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires drupal/twig_extensions 2.x-dev@dev -> satisfiable by drupal/twig_extensions[2.x-dev (alias of dev-2.x)].
    - drupal/core-recommended 10.2.0-beta1 requires drupal/core 10.2.0-beta1 -> satisfiable by drupal/core[10.2.0-beta1].
    - Conclusion: don't install drupal/core 10.2.0-beta1 (conflict analysis result)
    - drupal/core-recommended 10.2.0-rc1 requires drupal/core 10.2.0-rc1 -> satisfiable by drupal/core[10.2.0-rc1].
    - Conclusion: don't install drupal/core 10.2.0-rc1 (conflict analysis result)
    - drupal/core-recommended[10.1.7, ..., 10.1.x-dev] require twig/twig ~v3.6.0 -> satisfiable by twig/twig[v3.6.0, v3.6.1].
    - Conclusion: don't install twig/twig v3.6.1 (conflict analysis result)
    - drupal/core-recommended 10.2.0-alpha1 requires twig/twig ~v3.7.1 -> satisfiable by twig/twig[v3.7.1].
    - Conclusion: don't install twig/twig v3.7.1 (conflict analysis result)
    - drupal/core 10.2.x-dev conflicts with drush/drush <12.4.3.
    - drupal/core-recommended 10.2.x-dev requires drupal/core 10.2.x-dev -> satisfiable by drupal/core[10.2.x-dev].
    - Root composer.json requires drupal/core-recommended ^10.1.7 -> satisfiable by drupal/core-recommended[10.1.7, ..., 10.2.x-dev].
    - Root composer.json requires drush/drush ^11.0 -> satisfiable by drush/drush[11.0.0-rc1, ..., 11.x-dev].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
Composer [update] failed, composer command failed: exit status 2. stderr=

Prashant.c → made their first commit to this issue’s fork.

Any plans to proceed here? Perhaps someone would like to contact the maintainer @joelpittet about future plans for this module?

BTW I couldn't find any alternative to make advanced Twig functions like
https://twig.symfony.com/doc/3.x/filters/format_currency.html
https://twig.symfony.com/doc/3.x/filters/format_date.html

work, which point out:

The format_date filter is part of the IntlExtension which is not installed by default. Install it first:
$ composer require twig/intl-extra
Then, on Symfony projects, install the twig/extra-bundle:
$ composer require twig/extra-bundle

Otherwise, add the extension explicitly on the Twig environment:
use Twig\Extra\Intl\IntlExtension;
$twig = new \Twig\Environment(...);

I have contacted @joelpittet to see if we can get something merged so that we can proceed with this.