Refactor Claro's page-title stylesheet

Gauravvv → closed merge request !3389

Improved nesting of selectors. Please verify

Not sure if .region-header > .page-title {

But will let committer decide.

Using the @nest syntax would probably maker sense with the .region-header > .page-title selector.

Addressed #7, attached patch and interdiff. please review

Thanks looks good now!

Thoughts on this? 😇

Looks good code wise. Not aware of the @nest will have to look at that up.

+++ b/core/themes/claro/css/components/page-title.css
@@ -18,20 +18,20 @@
+   */

I'm not a fan of the complied file resulting in the comment appearing in a different block than what it is commenting on. I know it's not in the file being edited but it could still be inspected in browser tools. If there isn't a way to tweak the syntax to get that working in this issue scope, perhaps there should be another issue to address comment placement in the built file and this can be postponed on that.

Is there an inspector that shows CSS comments? 🤔 This should address the feedback but I'm not sure it's a good use of our time to optimize how comments appear in the generated CSS file.

The last submitted patch, 13: 3332428-14.patch, failed testing. View results →

Unrelated failure. restoring status

The last submitted patch, 13: 3332428-14.patch, failed testing. View results →

How's this for D11?

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions or other work to do.

Leaving at RTBC.

Committed 59d11a9 and pushed to 11.x. Thanks!

The patch had an issue it was setting the top margin instead of the bottom margin. Fixed on commit, applied patch here.

Automatically closed - issue fixed for 2 weeks with no activity.