The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
6 months ago 1:38pm 17 December 2023 - last update
6 months ago 30,766 pass - Status changed to RTBC
6 months ago 12:54am 20 December 2023 - 🇺🇸United States smustgrave
Confirmed the issue but using claro as my front-end theme.
Applying #83 addressed the issue and I'm seeing the same screenshots as currently in the issue summary.
Updated the issue summary to match the standard template.
- last update
6 months ago 30,743 pass, 12 fail - last update
6 months ago 30,763 pass, 14 fail - last update
6 months ago 30,744 pass, 15 fail - last update
6 months ago 30,758 pass, 13 fail - last update
6 months ago Build Successful - last update
6 months ago 30,764 pass, 13 fail - Status changed to Needs work
6 months ago 12:33am 31 December 2023 - 🇳🇿New Zealand quietone New Zealand
I'm triaging RTBC issues → . I read the IS and skimmed through the comments from #63 onwards. didn't find any unanswered questions or other work to do.
There are failing tests, setting to Needs work. Since DrupalCI is deprecated this should be on an MR now too.
I tested this on today on 11.x, standard install. Following the steps to reproduce in the issue summary, I was not able to reproduce the problem. The hint was in #84 that Claro should be the default theme. When I made the change I saw the problem, but only in the error message. There was no problem with the warning message. The steps to reproduce should be updated to state that Claro must be set to the default theme. I am tagging for an issue summary update.
I am only able to see the issue with the status message, not with the warning message.
Tested on Drupal 11- Merge request !5990drupal-3143237: Override the layout message icon. → (Open) created by shweta__sharma
- Status changed to Needs review
6 months ago 6:11am 2 January 2024 - 🇮🇳India Nitin shrivastava
@shweta__sharma
After applying the patch, it looks fine, but the 'done' mark, which was displayed just before the status message, has been removed.
before patch
After patch
- Status changed to Needs work
6 months ago 7:24am 2 January 2024 - 🇮🇳India Gauravvv Delhi, India
Gauravvvv → made their first commit to this issue’s fork.
- 🇮🇳India Gauravvv Delhi, India
Addressed #90.
Leaving to NW as this still requires issue summary update. Tested latest MR 5990 on Drupal 11. Changes have been updated layout builder icon with Claro is removed now.
Issue summary updated with latest UI changes. Added before/after screenshots.
Thanks- Status changed to Needs review
5 months ago 6:42am 17 January 2024 - Status changed to RTBC
5 months ago 4:41pm 24 January 2024 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
"Set claro as default theme" feels like an unlikely choice so lowering this to minor
- Status changed to Needs work
5 months ago 12:11am 8 February 2024 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Is the code in the 11.x MR correct? It seems to be removing the background. The 9.3 MR was doing something different.
Which one was correct? Based on comments/reviews from @lauriii and @bnjmnm it feels like they were in favour of the 9.3 approach, which seems lost in the 11.x MRSetting to needs work for clarification.
