- šŗšøUnited States smustgrave
Think the change from #9 should be included.
Outside of javascript files not sure we use
=== ""
Tagging for novice as it should be an easy update.
- Assigned to sourabhjain
- @sourabhjain opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 8:29am 20 February 2023 - š®š³India sourabhjain
Worked on #24 and rerolled the patch and created PR.
- Status changed to RTBC
almost 2 years ago 5:17pm 20 February 2023 - šŗšøUnited States smustgrave
Change looks good.
Verified locally that 1 test fails without the fix. Data set "Empty string" throws Symfony\Component\Serializer\Exception\UnexpectedValueException : The specified date "" is not in an accepted format: "Y-m-d\TH:i:sP" (RFC 3339), "Y-m-d\TH:i:sO" (ISO 8601).
- Status changed to Needs work
almost 2 years ago 8:01pm 20 February 2023 - š¦šŗAustralia larowlan š¦šŗš.au GMT+10
- š®š³India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
Fix the failed Patch For 10.1 version.
- š¦šŗAustralia larowlan š¦šŗš.au GMT+10
I think we still need a test-case for 0 as the patch didn't fail without it.
That probably means we need to expand the test method to accept an 'expected' denormalized value, which would default to the original value.
@Prem Suthar please be sure to add an interdiff ā when working with patches so reviewers can know what changed.
- šŗšøUnited States Kristen Pol Santa Cruz, CA, USA
Iām triaging for DrupalCon mentored contribution and reviewing as this issue is tagged novice.
*******
Please leave this issue for DrupalCon mentored contribution as a possible first time issue.*******
Next step is to update the test per the most recent comment. - šŗšøUnited States Kristen Pol Santa Cruz, CA, USA
Tag normalization happening:)