- 🇳🇿New Zealand quietone
closing as a duplicate of later issue, 📌 Map LoggerChannel Constants to PSR-3 rather than to RFC 5424 Closed: duplicate
- 🇺🇸United States mfb San Francisco
@quietone did you mean this is a duplicate of ✨ Make the map of PSR3 to RFC 5424 log level constants available as a constant Needs work ? I don't think it is a duplicate, as far as I can tell, speaking as someone who has commented on both issues and created one of them. So, if folks are interested in migrating to the PSR-3 log level constants they should probably re-open this issue.
- Status changed to Active
8 months ago 2:01am 6 May 2024 - 🇳🇿New Zealand quietone
@mfb, thanks so much. Yes, that is what I meant. But since this being a duplicate is in question, I have restored that status and added the one that I thought was a duplicate as related.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
kim.pepper → made their first commit to this issue’s fork.
- Status changed to Needs review
4 months ago 5:35am 28 August 2024 - 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
I created a MR for this just to see what would break.
The original rational for the decision (10 years ago) was for interoperability outside of PHP.
* @see https://groups.google.com/forum/#!topic/php-fig/Rc5YDhNdGz4
* @see https://www.drupal.org/node/2267545 →I think it's worth re-evaluating whether this is still a consideration in our current ecosystem.
- 🇺🇸United States smustgrave
There still seem to be some instances of RfcLogLevel: in the repo what's the rule of thumb for what should use RfcLogLevel vs the new approach?
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Rule of thumb is convert PSR level to RfcLogLevel if the logging implementation requires it. e.g. syslog.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
