Add aria-sort attribute to Views table output

Fixed failed commands on #48
Attached patch against Drupal 10.1.x

Hiding #50 as the issue is being addressed in the MR

Try To Fix the #50 Patch.

Fix The Custom CMD Patch Of mine.

New patch file to fix failing tests. Suggested to use patch files for tests since Gitlab branch testing seems stuck in the composer loop.

Can't you submit the changes to the MR? 3222 is having an issue because the code needs tweaked.

Think switching back n forth between MRs and patches causes noise and could delay this. just fyi.

Starting at comment #54 ✨ Add aria-sort attribute to Views table output Fixed patches have started to be used. The existing MR 3222 claims it is mergeable but when one tries, it fails with a composer error.

That composer error seems related to a gitlab infrastructure snafu that occurred around the time the MR was updated. Not it seems stuck.

Refactored #54 patch ✨ Add aria-sort attribute to Views table output Fixed with drupalcs reported issues fixed. Patch file for now until Gitlab composer issue for MR 3222 is addressed.

Removing the tests tag as they have been added.

But instead of adding a new file and bootstrapping a new instance think it would be best to extend an existing test.

Was searching around NodeAdminTest::testContentAdminSort. "Tests that the table sorting works on the content admin pages." think we could just add a line or two checking for the aria-label.

Verified this is working on Drupal 10.1 with a standard install.
Went to the admin content page
Verified I see aria-sort on the updated column
Clicked the column and aria-sort changed
Clicked a different column and aria-sort moved.

Thanks

Patch moves the aria-sort test into the existing NodeAdminTest PHP test as @smustgrave suggested, and removes the aria-sort specific test. Needs review to check if ->elementAttributeContains() method is enough for the testing needed.

Much better!

Please include an interdiff with the patches though.

Interdiff between patches #57 and #60. Thanks for the reminder @smustgrave.

Committed 4916764 and pushed to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.