- Merge request !2249Issue #2529170: Remove DrupalKernel::initializeRequestGlobals and replace base_root, base_url and base_path with a service → (Open) created by voleger
- Assigned to voleger
- 🇨🇦Canada joseph.olstad
Tried rebase via the merge request GUI, it fails. Feb 23 status looks green from the above comment description but I don't see the job, not sure where to find it.
- Status changed to Needs review
almost 2 years ago 5:53pm 26 February 2023 - 🇫🇷France andypost
Changed properties and fixed last usage, token changes looks like needs discussion
- Status changed to Needs work
almost 2 years ago 9:33pm 26 February 2023 - First commit to issue fork.
- Issue was unassigned.
- 🇺🇦Ukraine voleger Ukraine, Rivne
The issue appears on the Drupal\Tests\Core\Command\QuickStartTest run. It probably blocks the rest of the functional tests.
Any idea what is the cause of that behavior? - 🇫🇷France andypost
I guess it means that functional tests does not get request properly so url is not extracted, it reminds me somehow 📌 Add the session to the request in KernelTestBase, BrowserTestBase, and drush Fixed
- 🇺🇦Ukraine voleger Ukraine, Rivne
📌 Add the session to the request in KernelTestBase, BrowserTestBase, and drush Fixed looks great, let's wait when it will be fixed.
- 🇳🇿New Zealand quietone
Closed 📌 Remove LanguageNegotiationUrl's usage of base_path() Closed: duplicate as a duplicate, adding credit.
- 🇺🇦Ukraine voleger Ukraine, Rivne
I updated the PR, and I'm not sure why the `app` service was not initialized in most cases.