Incremental filter for permissions page

Testing MR 4564 on standard install of 11.x

Confirmed the search box appears as expected.
Searched for Block name, mobile description and got results

Clearing the box though with the X did not reset the page.

I tried this MR on a drupalpod. It could not install due to some composer issue, so I pulled the diff and applied manually. The filter shows up but does not work but that may be due to how I tested it (I cleared caches to make sure the aggregated JS is refreshed but that did not help). Since it did not work for me, I can only provide feedback on how it looks. The field description (under the field) is IMHO not needed (it is also not entirely grammatically correct). I think the field label though can be shown at all time like on the extend page. That would mostly bring them in line. The fieldset I am not sure why is present on the extend page, maybe for more contrib filters? Do we expect that to happen here?

Changes done as per 152:

• Description removed
• Label shown
• Fieldset like css added

I was not sure where to add the css for permissions page and for now I have done it at the same place where it is done for modules. This can be suggested in review. Thanks.

Does the module page has fieldset like CSS or an actual fieldset to contain potential contrib filters?

It has fieldset like css.

Confirmed my issue from #150 has been resolved.

Also was checking the drupal-live-announce region and that was updating correctly.

One think I'm not sure about is if a CR is needed.

But rest looks good!

It looks like we already have a follow-up for making this functionality more generic so that we don't have to keep duplicates of this (this is now third copy of this code). We could also convert some of the classes into data-attributes as part of that.

In terms of accessibility, usability, and technical implementation, this is identical to the pre-existing implementations. Therefore, I think this is good to go.

Committed b1eddcb and pushed to 11.x. Thanks!

lauriii → closed merge request !4564

I am setting the status back to NW, and adding issue tags, for a change record and a release-notes snippet.

This will go a long way towards making the Permissions form more manageable. I also notice that the filter appears on the module-specific and bundle-specific Permissions forms. For example:

I don't this needs an actual release note since this was only tagged to be mentioned in the release highlights. The release highlights are separate from the actual release notes, and is more focused on marketing aspects, i.e. promoting what's new in a specific release of Drupal.

Automatically closed - issue fixed for 2 weeks with no activity.

Great improvement, this makes handling permissions so much easier, thanks!