@hongpong Which is the status of merge? It needs more work to do or just revision?
Removed code that was reopening the editing sidepage after reloading.
Released version 1.0.1 version with this fix.
Hi @perke, probably you had old data from old field which is not compatible with the data that this module generates and this is why it is has not appeared until you create a new field with a different machine name.
I'm going to mark this as resolved and generate a new release version.
Created a fix for this issue.
Just added a default plugins for formatter and widget.
@perke can you take a look on it?
Hi @perke, I followed the steps and field is appearing for me.
Please, can you provide more information about your env?
Anyhow, have you tried to clear cache?
Created mr to fix it.
abarrio → created an issue.
Created merge request moving migrate_tools dependency from require-dev to require on composer.json to install it always.
Actually on each media is getting the default type and checking the extensions allowed there to get default value when configuring migration:
it is not different between types of attachment files, it is just getting them to drupal files and then converting it into media.
Removed unnecessary yml files from MR.
As I said on #26 I think we should work on those points but maybe we can proceed with this as a first approach and them complete the development in a follow up issue.
that's completely true!!
The only yml files that needs to be there are the ones from migrations folder.
I have been checking the error code part:
if ($this->currentConfig !== 0) {
$reset_current_config = reset($this->currentConfig);
}
if ($reset_current_config !== 0 && isset($reset_current_config[$field['field_name']]['dependencies'][$key])) {
$current_value = $reset_current_config[$field['field_name']]['dependencies'][$key];
}
I think that the correct way of those ifs should be checking if variable is empty because the currentConfig property is defined as array and comparing it to zero is not checking if at any case the variable is null.
The correct way should be: if (!empty($this->currentConfig)) {....
Makes sense to me.
Maybe we can merge and complete this issue as a first approach and then continue working on some other issues to finish this big development part.
I think we need a meta issue with a complete list of tasks needed to finish it. If I have time this days I'll create it.
No, I think there is more work remaining to have it as RTBC.
I think we still need to work on:
- Test each media type to check that is completely working automatically without changing yml
- Fix coding standard of all new code
- Maybe be able to check if xml file is completely correct to avoid problems when importing (Maybe could be done on a follow up issue)
- Create some unit tests
- Fix all problems that appears on merges
I think with this points resolved we can proceed with this as RTBC.
Uploaded one fix for an undefined index url error when executing drush ms and changed xpath expressions on media migrations with a simpler one.
Uploaded a fixing for the undefined property error and fixing some other coding standards on WordPressMigrationGenerator.
Created a new MR with branch 3173916-import-as-media rebased to 8.x-3.x.
Created merge request with solution to it.
On our project the exception was on encryption so I created a merge request with patch from #14 and added catching exception on encrypt method.
Reroll of patch from #144 to be used on 10.3.5 version.
It fixes my problem too. I think is RTBC too.
In my case I discovered that on my project the problem was with this issue this issue 🐛 Failed to start the session on view with flag content RTBC on flag module.
Add patch to use on compose project.
Changed localstorage to use sessionstorage and about the paragraph deletion behavior is controlled. It will not scroll.
Reroll of patch from #2 for version 4.0
Patch for version 10.3 to use on composer projects.
Added a control to check if file exist before calling file info.
Added patch to use on project.
Discovered that scroll should be done on 'load' window event because if not the scroll is not exact when page has lots of images.
Added commit fixing it.
Added patch too to be able to use new changes on project.
Modified last patch made on #4 to avoid deprecation on DomNodeInserted. Migrated code to Mutation observer API.
Fixed coding standard but still needs a work on tests.
Created merge with the js code moved to file 'admin-toolbar-wrapper.js'.
Upload patch to use it on composer project.
On our project we detected that on deleting paragraphs there was an error on js trying to scroll to an nonexistent element. Added a fix to control it on merge.
I agree with #6, I changed development to convert it into a new validation constraint.
Maybe tests with it are still needed.
I made a part of the development.
Added validation message on form.
Created merge request with needed changes.
The problem that I had is to recognise the component edited after reloading page.
Maybe we can use any storage option on backend when editing and then sending it to front when reloading.
Hi all.
the problem here is that on class ResponseSubscriber the code is using a functionality wich has been introduced on php 8.0.
You can see it here: https://www.php.net/manual/en/language.oop5.decon.php#language.oop5.decon.constructor.promotion
So I think a restriction should be added on composer to be installed on php 8.0+ platforms.