- Issue created by @larowlan
- First commit to issue fork.
- Assigned to bhaveshdas
- Issue was unassigned.
- 🇪🇸Spain abarrio
Created merge with the js code moved to file 'admin-toolbar-wrapper.js'.
- Status changed to Needs review
4 months ago 4:07pm 2 August 2024 - Status changed to Needs work
4 months ago 9:11pm 4 August 2024 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Thanks for this - there's some linting fails in the new file if you could resolve those - thanks!
- 🇷🇸Serbia finnsky
Inlining this script wasn't mistake. We wanted to have it executed right after render to avoid script loading. And use localstorage in most fastest way.
For me it is obvious not a Novice issue.
Since here we need to find golden middle between script execution time and CSP requirements. - 🇮🇳India nayana_mvr
I'm unable to reproduce this issue in D11 local setup navigation module enabled. I tried with CSP(Content Security Policy) module and Seckit (Security Kit) module. Couldn’t find any module named nginx rules. Is there any specific configuration to be done in the CSP or Seckit module to get that error? Also, does the error occur in login page itself or any of the admin page?
- 🇷🇸Serbia finnsky
@nayana_mvr
What can we do here?
The best thing is to add an instantly executable script(library) that will have no dependencies and will have the smallest weight. And doing the same thing that the inline script does now. It doesn't need Drupal or once. It even can start earlier than navigation is rendered.