- Issue created by @abarrio
- Issue was unassigned.
- Status changed to Needs review
6 months ago 3:17pm 28 June 2024 - 🇩🇪Germany a.dmitriiev
Another idea, maybe this scroll to should be an ajax command that is returned by `updateContent` method of `FrontendEditingController`?
- Status changed to Needs work
6 months ago 1:12pm 1 July 2024 - 🇩🇪Germany a.dmitriiev
Btw, thank you for your contribution, it is a great idea!
- 🇪🇸Spain abarrio
The problem that I had is to recognise the component edited after reloading page.
Maybe we can use any storage option on backend when editing and then sending it to front when reloading.
- 🇪🇸Spain abarrio
On our project we detected that on deleting paragraphs there was an error on js trying to scroll to an nonexistent element. Added a fix to control it on merge.
- 🇪🇸Spain abarrio
Discovered that scroll should be done on 'load' window event because if not the scroll is not exact when page has lots of images.
Added commit fixing it.Added patch too to be able to use new changes on project.
- 🇩🇪Germany a.dmitriiev
Let's maybe use the sessionStorage? If for some reason the localStorage was not emptied, it could lead to a problem that when you open the page after last time, it will try to scroll to some element, maybe even to the element that doesn't exist anymore. Also, have you considered the case when the paragraph is deleted?
- 🇪🇸Spain abarrio
Changed localstorage to use sessionstorage and about the paragraph deletion behavior is controlled. It will not scroll.
- Status changed to Needs review
about 2 months ago 9:58am 26 October 2024 -
a.dmitriiev →
committed 73de996a on 2.x
Issue #3457859 by abarrio, a.dmitriiev: Scroll to element not working
-
a.dmitriiev →
committed 73de996a on 2.x
Automatically closed - issue fixed for 2 weeks with no activity.