- Issue created by @almador
- π¬πͺGeorgia almador
Maybe this is related to php version?
I'm on Pantheon and it is set to 7.4 - πͺπΈSpain abarrio
Hi all.
the problem here is that on class ResponseSubscriber the code is using a functionality wich has been introduced on php 8.0.
You can see it here: https://www.php.net/manual/en/language.oop5.decon.php#language.oop5.decon.constructor.promotionSo I think a restriction should be added on composer to be installed on php 8.0+ platforms.
- Status changed to Needs work
over 1 year ago 9:10am 28 April 2023 - π¬π§United Kingdom unqunq
I'm getting the same error and I am on PHP 7.4. I tried upgrading but my site still uses some dependencies which are not ready for PHP 8+ making this impossible to use.
If anyone wants to get this working on PHP 7.4 then here is an article about the property promotion in PHP 8. https://stitcher.io/blog/constructor-promotion-in-php-8
I haven't tested the actual functionality of the module past fixing this file so there could be a lot more PHP 8 related parts that need downgraded in order to make this work with PHP 7.4
So I guess we just need to follow @abarrio's suggestion π syntax error, unexpected 'private' (T_PRIVATE), expecting variable (T_VARIABLE) in ResponseSubscriber.php:29 Fixed .
- First commit to issue fork.
- Status changed to Active
over 1 year ago 6:27pm 8 May 2023 - πΊπΈUnited States japerry KVUO
Can confirm. Module supports D9 and 7.4 via composer, but has PHP8+ syntax. An upcoming patch is going to remove PHP8+ syntax. In the meantime, I added PHP 7.4 testing, which should fail here.
- last update
over 1 year ago Build Successful - @japerry opened merge request.
- last update
over 1 year ago Build Successful - last update
over 1 year ago 51 pass, 4 fail - last update
over 1 year ago 54 pass - last update
over 1 year ago 54 pass - last update
over 1 year ago 54 pass -
japerry β
committed 2c762c52 on 2.0.x
Issue #3356646 by japerry: syntax error, unexpected 'private' (T_PRIVATE...
-
japerry β
committed 2c762c52 on 2.0.x
- Status changed to Fixed
over 1 year ago 4:24pm 9 May 2023 - πΊπΈUnited States pianomansam
Can we get a release with this fix included?
- π¬π§United Kingdom Tim Corkerton
I am on PHP7.4 Obviously I'd like the latest version but I am encountering this issue.
What is the recommended approach given that upgrading to PHP8 is not an option right now? - πΊπΈUnited States japerry KVUO
Yup, there should be a release by next tuesday (May 23). It wasn't our intention to drop support for PHP 7.4, so you can get the fix by updating to head or waiting until Tuesday for the full release.
- π¬π§United Kingdom Tim Corkerton
Thank you. I can confirm this works well with PHP7.4
Automatically closed - issue fixed for 2 weeks with no activity.